chore: refactor and enhance e2e test script #483
Merged
+492
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprashar2929
force-pushed
the
chore-e2e-sc
branch
2 times, most recently
from
e9a1747 to
01dc791
Compare
vprashar2929
changed the title
|
@vprashar2929 Thank you for the PR. |
This commit refactors the existing `e2e_test.sh` script, making it more
generic, modular.
Key updates include:
- Replaces the use of environment variables with command line arguments
for better clarity and flexiability.
```
💡 Examples:
# Run test with estimator
e2e_test.sh --estimator
# Run test with model server
e2e_test.sh --server
# Run test with dummy weight model or power request
e2e_test.sh --test
# Enable model database
e2e_test.sh --db
# Run test with both estimator and server
e2e_test.sh --estimator --server
# Run test with estimator, server, and model database
e2e_test.sh --estimator --server --db
```
- Test logs and other useful information are now stored in the `tmp/e2e` directory for better organization and accessibility.
- Adds a `utils.bash` file to store common utility functions
- Updates existing GH workflows to align with the refactored script and
adds a new step to upload test artifacts for easier debugging in case
of failures.
- Updates the `README.md` file
Signed-off-by: vprashar2929 <vibhu.sharma2929@gmail.com>
vprashar2929
force-pushed
the
chore-e2e-sc
branch
from
01dc791 to
80b4e35
Compare
sthaha
approved these changes
Oct 20, 2024
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the existing
e2e_test.shscript, making it moregeneric, modular.
Key updates include:
Replaces the use of environment variables with command line arguments
for better clarity and flexiability.
Test logs and other useful information are now stored in the
tmp/e2edirectory for better organization and accessibility.Adds a
utils.bashfile to store common utility functionsUpdates existing GH workflows to align with the refactored script and
adds a new step to upload test artifacts for easier debugging in case
of failures.
Updates the
README.mdfileAddresses #452 #469
Checklist for PR Author
In addition to approval, the author must confirm the following check list:
Run the following command to format your code:
Create issues for unresolved comments and link them to this PR. Use one of the following labels:
must-fix: The logic appears incorrect and must be addressed.minor: Typos, minor issues, or potential refactoring for better readability.nit: Trivial issues like extra spaces, commas, etc.