feat: add compute similarity and loose selection #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunya-ch
force-pushed
the
server-api-rebase-patch-2
branch
from
918642d to
0805fa2
Compare
sunya-ch
force-pushed
the
server-api-rebase-patch-2
branch
2 times, most recently
from
dcf2001 to
a42aa84
Compare
sunya-ch
force-pushed
the
server-api-rebase-patch-2
branch
2 times, most recently
from
1a89af2 to
0477e0b
Compare
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
sunya-ch
force-pushed
the
server-api-rebase-patch-2
branch
from
0477e0b to
ffdaee8
Compare
sthaha
reviewed
Aug 26, 2024
Comment on lines
+153
to
+154
| tests/db-models | ||
| db-models |
There was a problem hiding this comment.
minor: Shall we use this PR to start keeping all tmp files for tests under tmp/tests directory?
sthaha
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back the previous reverted PR: #370 with issue addressed.
Signed-off-by: Sunyanan Choochotkaew sunyanan.choochotkaew1@ibm.com