Added more support for PHILIPS #17
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds filtering rules for three additional Philips CT scanner models to the Stanford filter script. The changes enable proper handling of DICOM images from BRILLIANCE 64, VEREOS PET/CT, and GEMINI TF TOF 16 scanners.
Changes:
- Added filter rule for Philips BRILLIANCE 64 CT scanner with MXVIEW software version 3.6.8
- Added filter rule for Philips VEREOS PET/CT scanner supporting both standard and large resolution images
- Added filter rule for Philips GEMINI TF TOF 16 scanner with exclusions for dose info and burned-in annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
|
|
||
| // Philips CT - BRILLIANCE 64 | ||
| +( Manufacturer.startsWithIgnoreCase("Philips") |
There was a problem hiding this comment.
All three new filter rules have trailing whitespace after the opening parenthesis on the manufacturer check line. This is inconsistent with the existing code style in the file and should be removed for consistency.
| ) | ||
|
|
||
| // Philips CT - VEREOS PET/CT AXIAL | ||
| +( Manufacturer.startsWithIgnoreCase("Philips") |
There was a problem hiding this comment.
All three new filter rules have trailing whitespace after the opening parenthesis on the manufacturer check line. This is inconsistent with the existing code style in the file and should be removed for consistency.
| ) | ||
|
|
||
| // Philips CT - GEMINI TF TOF 16 AXIAL | ||
| +( Manufacturer.startsWithIgnoreCase("Philips") |
There was a problem hiding this comment.
All three new filter rules have trailing whitespace after the opening parenthesis on the manufacturer check line. This is inconsistent with the existing code style in the file and should be removed for consistency.
| * [0018,1018].startsWithIgnoreCase("MXVIEW") | ||
| * ([0018,1020].equalsIgnoreCase("3.6.8")) | ||
| * ( | ||
| (Rows.equals("512") * Columns.equals("512")) |
There was a problem hiding this comment.
The closing parentheses for the row/column dimension checks have inconsistent indentation (4 spaces) compared to the surrounding code structure. These should be aligned with the opening parenthesis on the previous lines (typically 5 spaces based on the surrounding context).
| (Rows.equals("512") * Columns.equals("512")) | |
| (Rows.equals("512") * Columns.equals("512")) |
| * ( | ||
| (Rows.equals("512") * Columns.equals("512")) | ||
| + (Rows.equals("2142") * Columns.equals("1332")) | ||
| ) |
There was a problem hiding this comment.
The closing parentheses for the row/column dimension checks have inconsistent indentation (4 spaces) compared to the surrounding code structure. These should be aligned with the opening parenthesis on the previous lines (typically 5 spaces based on the surrounding context).
| ) | |
| ) |
| * ([0018,1020].equalsIgnoreCase("2.3.0")) | ||
| * ( | ||
| (Rows.equals("512") * Columns.equals("512")) | ||
| ) |
There was a problem hiding this comment.
The closing parentheses for the row/column dimension checks have inconsistent indentation (4 spaces) compared to the surrounding code structure. These should be aligned with the opening parenthesis on the previous lines (typically 5 spaces based on the surrounding context).
| ) | |
| ) |
1 participant
No description provided.