Extension stuck loading for songs without lyrics

[AdrisAz]

How did you install Beautiful Lyrics?

Marketplace

What is the Bug/Issue?

The extension loads infinitely in both the sidebar and fullscreen mode when encountering a song without lyrics.

What Country are you from?

Canada

What Operating System are you using?

Windows

Spotify/Spicetify Information

Spotify Version: 1.2.49.439.gfae492c7
Spotify Runtime: cef_129.0.11+g57354b8+chromium-129.0.6668.90
Spicetify Version: 2.38.4
Spicetify Theme: marketplace
Spicetify Extensions: [beautiful-lyrics.js, hidePodcasts.js, goToSong.js, fullAlbumDate.js, playNextWrapper.js, imageOpener.js, CoverAmbience.js, oneko.js, copytoclipboard.js, made-for-you-shortcut.js, playbarClock.js, showQueueDuration.js, spotispy.js, shuffle+.js, AnonymizedRadios.js, cat-jam.js, beautiful-lyrics.mjs]
Spicetify Custom Apps: [marketplace]

Spotify HTML/CSS and Console Screenshots

Spotify.zip

Information Checklist

• Spotify/Spicetify Information
• Spotify HTML File
• Spotify CSS File
• Screenshots of Developer Tools Console Tab

[zero-mindset]

I have this same issue (MacOS Sonoma 14.1) as well. This occurs on songs without lyrics, but also songs without synced lyrics

[AdrisAz]

I think it's happening with non-synced lyrics for me too actually.

[SpikeNew7774]

It must've happened due to the server returning a 500 Errror status Code. Let me explain.
I've checked out the extension code, and found out that when the "https://beautiful-lyrics.socalifornian.live" server returns a different status code than 200, the extension doesn't know what to do and then it never hides the loading status. The only way to report it to the extension, that there are no lyrics, the server would have to return an empty body with the status code of 200.

[HeyitsRadinn]

+1 same issue for me, multiple computers and networks

[SpikeNew7774]

I mean you could edit the actual built file for beautiful lyrics and do all that, but If you are a dev, you could just make your own beautiful lyrics. (im in the middle of doing that)

[zero-mindset]

Could you make an option to turn off the background colors in the Now Playing section?

…

On Tue, Nov 5, 2024 at 1:39 PM SpikeNew7774 ***@***.***> wrote: I mean you could edit the actual built file for beautiful lyrics and do all that, but If you are a dev, you could just make your own beautiful lyrics. (im in the middle of doing that) — Reply to this email directly, view it on GitHub <#966 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5MWCYFOYWTSKA5PTCTENU3Z7ENGFAVCNFSM6AAAAABRDMSXRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYGAYTAOBXGQ> . You are receiving this because you commented.Message ID: ***@***.***>

[SpikeNew7774]

@zero-mindset Do you mean that in the Beautiful-Lyrics extension or in the one that I'm making (I'm thinking of publishing it later)

[zero-mindset]

Either or. I just figured you’d take what was existing and make tweaks to that. To me, that’s the only flaw with the current BL design

…

On Tue, Nov 5, 2024 at 2:19 PM SpikeNew7774 ***@***.***> wrote: @zero-mindset <https://github.com/zero-mindset> Do you mean that in the Beautiful-Lyrics extension or in the one that I'm making (I'm thinking of publishing it later) — Reply to this email directly, view it on GitHub <#966 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5MWCYGJHMI6A2A65AR4GL3Z7ER4VAVCNFSM6AAAAABRDMSXRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYGA3TQOJVHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[SpikeNew7774]

I could have a look into that, but if you would want it, it would need to be externally installed and not through the marketplace. I'm probably going to edit the actual output file and not the source code in this github repo -> (PS: Its tooooooooooo complicated for me).

[Lebbbbb]

Anyone find a fix for this?

[SpikeNew7774]

Kind of. Its a problem on the server, which could be fixed by adding a check if the response status isnt 200 to just hide the lyrics in the actual client code. Also I found out that if the lyrics are static on apple music, it will return a 500 error with the content about a 429 error. Response Body: "Stage: AM_S, Error: 429 | Too Many Requests"

[httpeace33]

I've got same issue for few days for almost all lyrics tho(

[SpikeNew7774]

That means their API must be failing. I'm currently making my own Apple Musix => JSON API that's compatible with the beautiful-lyrics format (I'm using it in my own Lyrics extension)