Skip to content

Conversation

@gsilvapt
Copy link
Contributor

@gsilvapt gsilvapt commented May 2, 2023

This migration will fail until #123 is merged.

@gsilvapt gsilvapt requested a review from a team as a code owner May 2, 2023 11:16
@gsilvapt gsilvapt requested review from bogdanoniga and cojoeu May 2, 2023 11:16
@gsilvapt gsilvapt force-pushed the misc-checkmigrations branch from 63807ad to 092ac60 Compare May 2, 2023 14:01
@gsilvapt gsilvapt requested a review from fopina May 11, 2023 07:58
@gsilvapt gsilvapt added this to the v1.2.0 milestone May 11, 2023
Copy link
Contributor

@fopina fopina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could do it in separate job to avoid doing it in the matrix? Not exactly sure about best way due to missing the docker build but maybe the build should also be out of the matrix?

@gsilvapt
Copy link
Contributor Author

Maybe we could do it in separate job to avoid doing it in the matrix? Not exactly sure about best way due to missing the docker build but maybe the build should also be out of the matrix?

Get the idea, yea, but that will mean setting a database service just for this purpose. It's acceptable, I guess.

@fopina
Copy link
Contributor

fopina commented May 11, 2023

True but it can be kept clean by using yaml anchors (second definition would be just the anchor)

@gsilvapt
Copy link
Contributor Author

True but it can be kept clean by using yaml anchors (second definition would be just the anchor)

Not sure if that's going to work: actions/runner#1182 and ChatGPT agrees (😂 )
image

A bit of copy pasting is acceptable, I guess.

gsilvapt added 2 commits May 12, 2023 11:00
So it only runs once, without needing to run through all cases in the
matrix.
@gsilvapt gsilvapt merged commit ce0666b into main May 12, 2023
@gsilvapt gsilvapt deleted the misc-checkmigrations branch May 12, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants