issue: #185: use revealLine for line update #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #185
The solution was to use
revealLine
instead ofsetScrollPosition
(which works with pixel values instead of line)Also as it turns out, there are 3 methods:
revealLine
,revealLineInCenter
andrevealLineNearTop
. I'm not sure if it's a good idea to add this complexitytoEditor
's props or to choose a different default behavior formonaco-react
library.