Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review first: Remove .NET Standard 2.1 Dependency & Fix Scripting Restore #113

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

RobProductions
Copy link
Contributor

Fixes #111 as mentioned in #112 and also restores scripting backend after build as mentioned in #112.

Unfortunately since I use 2020.3 I can't even compile to test my other smaller feature branches without including the changes from this PR so the best I can do is to keep this as its own. The other PRs will have merged the commits from this PR but you can safely ignore that; once this is merged they won't appear as file differences I believe. Apologies for that!

string.Join(char,etc.) and Enumerable.SkipLast were introduced in versions above .NET Standard 2.0. Standard 2.0 is still supported by Unity 2020.3 which resulting in me getting compiler errors with that LTS version
@RobProductions RobProductions changed the title Remove .NET Standard 2.1 Dependency & Fix Scripting Restore Review first: Remove .NET Standard 2.1 Dependency & Fix Scripting Restore Jun 2, 2023
@RobProductions
Copy link
Contributor Author

Hey @robinnorth apologies for the persistence, but is there any update on getting these merged in? As it's been over a month now it's actually getting closer to beta build time for my game and I was hoping to use the new features here haha. That's besides the fact that I can't even use the latest version in my projects due to the errors which this PR fixes. I also had a few more ideas I wanted to tackle and submit as PRs but I'm waiting until we're sure that these can merge in successfully to avoid further complications/conflicts.

Thanks and let me know if there's anything else I can do to help with the process!

@robinnorth
Copy link
Collaborator

Hey @RobProductions, sorry for the delay and thanks for your patience. I've been incredibly busy this last month and haven't had a chance to review the changes yet. I will try and do so this week, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants