Skip to content

fix: oidc urls and golang type fix #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Conversation

sattvikc
Copy link
Contributor

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Checklist

  • Algolia search needs to be updated? (If there is a new sub docs project, then yes)
  • Sitemap needs to be updated? (If there is a new sub docs project, then yes)
  • Checked for broken links? (Run cd v2 && MODE=production npx docusaurus build)
  • Changes required to the demo apps corresponding to the docs?

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for admiring-bhabha-7b1be9 ready!

Name Link
🔨 Latest commit f931e54
🔍 Latest deploy log https://app.netlify.com/sites/admiring-bhabha-7b1be9/deploys/66a89a7a00af6f00086fe167
😎 Deploy Preview https://deploy-preview-819--admiring-bhabha-7b1be9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -326,7 +326,7 @@ async function createTenant() {
scope: ["email", "profile"]
}],
// highlight-start
oidcDiscoveryEndpoint: "https://example.com",
oidcDiscoveryEndpoint: "https://example.com/.well-known/openid-configuration",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is text around this snippet that says that we do not add the wellknown path. That needs to be removed.

@sattvikc sattvikc changed the title fix: oidc urls fix: oidc urls and golang type fix Jul 30, 2024
@rishabhpoddar rishabhpoddar merged commit 8b77a10 into master Jul 30, 2024
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the oidc-endpoint-fixes branch July 30, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants