Polymesh improvements#103
Closed
Bud-Macaulay wants to merge 3 commits intosuperstar54:mainfrom
Closed
Conversation
Collaborator
Author
|
If possible, it might be nice to test this change with AnyMesh (i dont think that uses DoubleSide...) I think in principle this should allow anymeshes to render behind polyhedra better, but the otherway around may not be changed. |
Collaborator
Author
|
Closing as outdated w.r.t the materialscloud branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the polyhedral rendering has a small issue where it does not to respect transparency and correct rendering is a function of camera position.
Image 1: Transparency works as expected, behind polyhedra are rendering correctly
Rotation by 180 around b:
Image 2: Transparency does not work as expect
Instead, ive switched the mesh rendering side to be Three.DoubleSide, this allows rendering out the box,
Additionaly, i've added edge drawing to these polyhedra, this probably comes with a small performance hit (but im fairly sure its minimal at best.) showEdges=true
The showEdges flag could be exposed to the controller api, both color, transparency and on/off so that these can be toggled in the controls panel., but this is not currently done.