Open
Conversation
Non-interleaved support was added in f229c7b Previous to this commit, the default was interleaved, meaning there was only ever one mBuffers. With non-interleaved support, there are numberOfChannels mBuffers. The allocation of these buffers is shown in createInputBuffer wherein if (interleaved) { ... inputBuffer->mBuffers[0].mData = calloc(1, MAXFRAMES * 4 * numberOfChannels); ... } else { inputBuffer = (AudioBufferList *)malloc(offsetof(AudioBufferList, mBuffers[0]) + sizeof(AudioBuffer) * numberOfChannels); ... for (int n = 0; n < numberOfChannels; n++) { inputBuffer->mBuffers[n].mData = inputBufs[n] = (float *)calloc(1, MAXFRAMES * 4); ... } } Therefore when freeing inputBuffer, interleaved == true should free one mBuffers and interleaved == false should free numberOfChannels mBuffers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-interleaved support was added in f229c7b
Previous to this commit, the default was interleaved, meaning there was only ever one mBuffers.
With non-interleaved support, there are numberOfChannels mBuffers.
The allocation of these buffers is shown in createInputBuffer wherein
Therefore when freeing inputBuffer, interleaved == true should free one mBuffers and interleaved == false should free numberOfChannels mBuffers.