Fix serial consoles and images #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In upstream commit 9d053af1fb570b4e3483de4ecd6827e1e0be61b7 (mickledore), the SERIAL_CONSOLE variable was removed. This prevented the serial consoles from working. Change to get it working again. Signed-off-by: Jon Mason <jdmason@kudzu.us>
Upstream commit 26d97acc71379ab6702fa54a23b6542a3f51779c (nanbield) contains a change which breaks linking of images without IMAGE_NAME_SUFFIX set. Add an empty string to get this working again. Signed-off-by: Jon Mason <jdmason@kudzu.us>
bmaptool can handle compression. Let's compress the wic file to save space in the build tree. Signed-off-by: Jon Mason <jdmason@kudzu.us>
|
I should probably add this was tested on a AML-S905X-CC board and verified to work (but only tested on that platform). Also, please cherry pick the relevant changes back to the mickledore and nanbield branches as those don't work without them. |
|
Yep, I wanted to wait for CI to finish, but it keeps failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code no longer boots and serial consoles do not work (since nanbield and mickledore respectively). Fix those and compress the wic image for developer ease-of-use.