Skip to content

Commit

Permalink
test macos code signing
Browse files Browse the repository at this point in the history
  • Loading branch information
supermerill committed May 15, 2022
1 parent 2e11c48 commit bda609f
Showing 1 changed file with 23 additions and 2 deletions.
25 changes: 23 additions & 2 deletions .github/workflows/ccpp_mac_rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,32 @@ jobs:
ref: 'rc'
- name: build deps & slicer
run: ./BuildMacOS.sh -i
- name: Codesign executable conf
env:
MACOS_CERTIFICATE: ${{ secrets.MACOS_P12 }}
MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_PASSWD }}
run: |
echo $MACOS_CERTIFICATE | base64 --decode > certificate.p12
security create-keychain -p temp_password build.keychain

This comment has been minimized.

Copy link
@timschneider

timschneider Mar 20, 2023

@supermerill that can expose your private developer id, when you someday don't think of it and expose the build folder.
MACOS_KEYCHAIN_PASSWORD: ${{ secrets.MACOS_KEYCHAIN_PASSWORD }}
security create-keychain -p "$MACOS_KEYCHAIN_PASSWORD" build.keychain
and use a strong password should be better.

security default-keychain -s build.keychain
security unlock-keychain -p temp_password build.keychain
security import certificate.p12 -k build.keychain -P $MACOS_CERTIFICATE_PWD -T /usr/bin/codesign
- name: verify certificate presence
run: security find-identity -v
- name: register codesign
run: |
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k temp_password build.keychain
- name: run codesign on app
run: |
/usr/bin/codesign --force -s "Developer ID Application: Remi Durand (LDTLFRHP3G)" ./build/pack/SuperSlicer/SuperSlicer.app -v
- name: Upload artifact
uses: actions/upload-artifact@v1.0.0
with:
name: rc_macos.tar
path: build/SuperSlicer.tar
name: rc_macos.app
path: build/pack/SuperSlicer/SuperSlicer.app
- name: run codesign on dmg
run: |
/usr/bin/codesign --force -s "Developer ID Application: Remi Durand (LDTLFRHP3G)" ./build/SuperSlicer.dmg -v
- name: Upload artifact
uses: actions/upload-artifact@v1.0.0
with:
Expand Down

0 comments on commit bda609f

Please sign in to comment.