Repository navigation
fix(raycast): display zero relevance scores - #1710
Open
vivekvar-dl wants to merge 2 commits into
Open
vivekvar-dl wants to merge 2 commits into
vivekvar-dl wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search accepts a zero relevance threshold, so a result can legitimately have
score: 0. The Raycast extension used truthiness checks and hid that value in both the result list and detail view.Check for
undefinedinstead so zero renders as0%while an omitted score remains hidden.Verification
bunx biome check src/search-memories.tsxnpm run buildinapps/raycast-extensionnpx tsc --noEmit -p tsconfig.jsongit diff --checkRepository-wide checks
bun run format-lint— blocked by existing repository diagnostics (3 errors and 104 warnings, including Biome schema-version mismatches); no fixes were appliedbun run check-types— blocked in the unchangedpackages/ui/components/shadcn-io/dropzone.tsxbecausereact-dropzoneis not declared/installedbun run build— all 7 build tasks completed successfully; the root command then failed inpostbuildbecause the Sentry upload requires a maintainer auth tokenAdditional regression coverage
bun test src/relevance-score.test.ts(3 passed)bunx biome check apps/raycast-extension/src/search-memories.tsx apps/raycast-extension/src/relevance-score.ts apps/raycast-extension/src/relevance-score.test.tsScreenshots
Not included: the development command reaches the Supermemory API-key setup screen, and reproducing an exact zero-score response requires authenticated live data. The zero-score list/detail behavior is covered by the focused regression test instead.