code cleanup

superhize · Nov 1, 2024 · 8ddb3d4 · 8ddb3d4
1 parent b01a485
commit 8ddb3d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/main/java/at/hannibal2/skyhanni/api/SkillAPI.kt b/src/main/java/at/hannibal2/skyhanni/api/SkillAPI.kt
@@ -43,6 +43,7 @@ import kotlin.time.Duration.Companion.seconds
 @SkyHanniModule
 object SkillAPI {
     private val patternGroup = RepoPattern.group("api.skilldisplay")
+    // TODO add regex tests
     private val skillPercentPattern by patternGroup.pattern(
         "skill.percent",
         "\\+(?<gained>[\\d.,]+) (?<skillName>.+) \\((?<progress>[\\d.]+)%\\)",

diff --git a/src/main/java/at/hannibal2/skyhanni/features/skillprogress/SkillUtil.kt b/src/main/java/at/hannibal2/skyhanni/features/skillprogress/SkillUtil.kt
@@ -70,10 +70,7 @@ object SkillUtil {
         var overflowXp = 0L
 
         if (level >= maxLevel) {
-            val xpNeeded = when (maxSkillCap) {
-                50 -> XP_NEEDED_FOR_50
-                else -> XP_NEEDED_FOR_60
-            }
+            val xpNeeded = if (maxSkillCap == 50) XP_NEEDED_FOR_50 else XP_NEEDED_FOR_60
 
             if (currentXp >= xpNeeded) {
                 overflowXp = currentXp - xpNeeded