Decode command exit frames correctly - #12
Merged
Merged
Conversation
aezell
force-pushed
the
alex/issue-6-control-close
branch
from
July 31, 2026 10:06
7aa990b to
abce09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gun_downgun_downpathsUser impact
Commands record their exit status before the WebSocket closes, preventing successful calls from surfacing as
Command failed: :closed. The decoder also handles empty or extended exit frames consistently with the Go, JavaScript, and Python SDKs.Validation
Sprites.hello/0SPRITE_TOKENorSPRITE_NAMEconfiguredVersioning and deployment
This is a backwards-compatible SDK correction now that control mode is on
main. The package manifest remains at0.1.0; include this fix in the next SDK release. No service deployment is required.Fixes #6.