Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add logging around testDeployNodeApp* tests #3945

Merged
merged 1 commit into from
Sep 17, 2024
Merged

test: add logging around testDeployNodeApp* tests #3945

merged 1 commit into from
Sep 17, 2024

Conversation

kzys
Copy link
Member

@kzys kzys commented Sep 17, 2024

These tests were sometimes really slow (TestDeployNodeApp/With_Depot took more than seven minutes in the run below).

Logging the app name would be helpful for troubleshooting.

https://github.com/superfly/flyctl/actions/runs/10895447430/job/30233905656?pr=3944#step:7:48

Change Summary

What and Why:

How:

Related to:


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

These tests were sometimes really slow (TestDeployNodeApp/With_Depot
took more than seven minutes in the run below).

Logging the app name would be helpful for troubleshooting.

https://github.com/superfly/flyctl/actions/runs/10895447430/job/30233905656?pr=3944#step:7:48
@kzys kzys marked this pull request as ready for review September 17, 2024 17:03
@kzys
Copy link
Member Author

kzys commented Sep 17, 2024

We'll get the output like this.

=== NAME  TestDeployNodeApp/With_Wireguard
    fly_volume_test.go:24: 03:17:24 workdir /tmp/TestDeployNodeAppWith_Wireguard25[43](https://github.com/superfly/flyctl/actions/runs/10895811904/job/30238115692?pr=3945#step:7:44)575208/001
=== NAME  TestDeployNodeApp/Without_Wireguard
    fly_volume_test.go:24: 03:17:24 workdir /tmp/TestDeployNodeAppWithout_Wireguard385309648/001
=== NAME  TestDeployNodeApp/With_Depot
    fly_volume_test.go:24: 03:17:25 workdir /tmp/TestDeployNodeAppWith_Depot631511855/001
=== NAME  TestDeployNodeApp/With_Wireguard
    fly_volume_test.go:24: 03:17:25 deploy preflight-pf-gha-70bc8dba-2024-09-mq2a2fqz
=== NAME  TestDeployNodeApp/With_Depot
    fly_volume_test.go:24: 03:17:25 deploy preflight-pf-gha-70bc8dba-2024-09-dvj3qsyz with Depot
=== NAME  TestDeployNodeApp/Without_Wireguard
    fly_volume_test.go:24: 03:17:25 deploy preflight-pf-gha-70bc8dba-2024-09-3skb7byz without WireGuard
=== NAME  TestDeployNodeApp/With_Depot
    fly_volume_test.go:24: 03:18:24 deploy preflight-pf-gha-70bc8dba-2024-09-dvj3qsyz again with Depot
=== NAME  TestDeployNodeApp/With_Wireguard
    fly_volume_test.go:24: 03:18:24 deploy preflight-pf-gha-70bc8dba-2024-09-mq2a2fqz again
--- PASS: TestDeployNodeApp (0.00s)
    --- PASS: TestDeployNodeApp/With_Depot (131.61s)
    --- PASS: TestDeployNodeApp/Without_Wireguard (171.[49](https://github.com/superfly/flyctl/actions/runs/10895811904/job/30238115692?pr=3945#step:7:50)s)
    --- PASS: TestDeployNodeApp/With_Wireguard (216.14s)

Copy link
Member

@dangra dangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kzys kzys merged commit 9ecc149 into master Sep 17, 2024
34 checks passed
@kzys kzys deleted the deploy-log branch September 17, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants