Fix bug making local-only impossible #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way actions invoked the entrypoint, $* gave us the args in a string so we never succeeded unless the only argument to deploy was `--local-only`, instead we ended up with e.g. `flyctl deploy --local-only -some-arg --remote-only` `--local-only` and `--remote-only` cancel each other out and we're left unable to deploy. Also fixes an a bug where we repeated the local strategy e.g. `flyctl deploy --local-only --local-only`
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is unrelated to #14 but can be applied on top of it, they address different issues.
The issue is that
$*ends up giving us all the arguments a string, so you're comparing"deploy --local-only"with--local-only, and you end up running the commandflyctl deploy --local-only --remote-only. This can't deploy because they cancel each-other out :)