Add hint about specifying dockerfile in case it is not automatically … #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detected I have a Rails app which has a dockerfile named `Dockerfile` in a main directory and still `fly launch` was still trying to build it as a ruby app, hence I'm adding this hint.
rubys
requested changes
Jul 23, 2023
| @@ -31,7 +31,7 @@ Wrote config file fly.toml | |||
| ? Would you like to deploy now? | |||
| ``` | |||
|
|
|||
| Let `fly launch` generate an app name for you or pick your own. | |||
| Let `fly launch` generate an app name for you or pick your own. You may need to explicitily specify Dockerfile path using `--dockerile` flag if fly doesn't detect Dockerfile automatically. | |||
There was a problem hiding this comment.
There are two typos in that one sentence.
| @@ -31,7 +31,7 @@ Wrote config file fly.toml | |||
| ? Would you like to deploy now? | |||
| ``` | |||
|
|
|||
| Let `fly launch` generate an app name for you or pick your own. | |||
| Let `fly launch` generate an app name for you or pick your own. You may need to explicitily specify Dockerfile path using `--dockerile` flag if fly doesn't detect Dockerfile automatically. | |||
There was a problem hiding this comment.
The issue isn't that fly doesn't detect the Dockerfile automatically, successfully launching a Rails application typically requires the setting of at least one secret (RAILS_MASTER_KEY), and either the deployment of a database or the creation of a volume. That's why the scanner for Rails is run before the Dockerfile scanner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…detected
I have a Rails app which has a dockerfile named
Dockerfilein a main directory and stillfly launchwas trying to build it as a ruby app, hence I propose adding this hint.