Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make selfMint requireReceptionAck=false #353

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Make selfMint requireReceptionAck=false #353

merged 1 commit into from
Jul 5, 2021

Conversation

ngmachado
Copy link
Contributor

No description provided.

@ngmachado ngmachado requested a review from hellwolf July 1, 2021 12:50
@ngmachado ngmachado linked an issue Jul 1, 2021 that may be closed by this pull request
selfMint requireReceptionAck is hard-coded to true #345
Closed
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

📦 PR Packages

Install this PR (you need to setup Github packages):

yarn add @superfluid-finance/js-sdk@PR353
yarn add @superfluid-finance/ethereum-contracts@PR353
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your .npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@hellwolf hellwolf changed the title fix #345 Make selfMint requireReceptionAck=false Jul 5, 2021
hellwolf
hellwolf approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hellwolf hellwolf merged commit fd42afb into dev Jul 5, 2021
@hellwolf hellwolf deleted the fix345 branch July 5, 2021 12:16
saflamini pushed a commit that referenced this pull request Oct 16, 2021
@codenamejason
Merge pull request #353 from kenonchain/run-prettier-to-fix-lint-errors
616ac80 
Run prettier to fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selfMint requireReceptionAck is hard-coded to true
2 participants
@ngmachado @hellwolf