[sdk-core] new Operation types and ETH value forwarding #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2042 +/- ##
==========================================
+ Coverage 88.09% 88.19% +0.10%
==========================================
Files 109 109
Lines 6793 6851 +58
Branches 978 985 +7
==========================================
+ Hits 5984 6042 +58
Misses 807 807
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hellwolf
approved these changes
Dec 13, 2024
kasparkallas
commented
Dec 13, 2024
| const values = operationStructArray | ||
| .filter((x) => x.value?.gt(BigNumber.from(0))) | ||
| .map((x) => x.value); | ||
|
|
There was a problem hiding this comment.
A possible situation to protect against would be that the operation with the ETH value would be the first payable call in the set of operations.
d10r
approved these changes
Dec 13, 2024
XKCD Comic RelifLink: https://xkcd.com/2042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: bump version & changelog