[subgraph][fix] explicitly build in the subgraph deploy script for Goldsky #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
hellwolf
approved these changes
Apr 9, 2024
XKCD Comic RelifLink: https://xkcd.com/1925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
The
graph deploytriggersgraph buildimplicitly butgoldsky subgraph deploydoesn't. When testing locally thedeploy.sh, I made the assumption that the subgraph has been built earlier in the workflow chain, but it isn't.How?
Explicitly call
graph buildfor the Goldsky step.