Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Metadata Version #1507

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Bump Metadata Version #1507

merged 4 commits into from
Jul 13, 2023

Conversation

msoni89
Copy link
Contributor

@msoni89 msoni89 commented Jul 12, 2023

No description provided.

@github-actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.60 🎉

Comparison is base (3cd1f8a) 87.33% compared to head (22bdfaa) 95.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1507      +/-   ##
==========================================
+ Coverage   87.33%   95.93%   +8.60%     
==========================================
  Files          91       41      -50     
  Lines        4389     2139    -2250     
  Branches      184        0     -184     
==========================================
- Hits         3833     2052    -1781     
+ Misses        512       87     -425     
+ Partials       44        0      -44     
Flag Coverage Δ
ethereum-contracts 95.93% <ø> (ø)
sdk-core ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xdavinchee
Copy link
Contributor

gm! You've bumped the versions of the other packages, this was probably not intentional

@msoni89 msoni89 force-pushed the bump_metadata_version branch from cd86b40 to e1ffccd Compare July 12, 2023 12:34
Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xdavinchee 0xdavinchee merged commit 986180d into dev Jul 13, 2023
@0xdavinchee 0xdavinchee deleted the bump_metadata_version branch July 13, 2023 07:44
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1507
https://xkcd.com/1507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants