Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing metadata types into list.d.ts #1505

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

msoni89
Copy link
Contributor

@msoni89 msoni89 commented Jul 12, 2023

No description provided.

@msoni89 msoni89 requested a review from a team as a code owner July 12, 2023 09:05
@@ -9,6 +9,9 @@ interface ContractAddresses {
readonly superTokenFactory: string;
readonly superfluidLoader: string;
readonly toga: string;
Copy link
Contributor Author

@msoni89 msoni89 Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, how its working but toga is an option field but here it's string types.

Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - LGTM

@0xdavinchee 0xdavinchee merged commit c99f6f9 into dev Jul 12, 2023
@0xdavinchee 0xdavinchee deleted the fix_missing_metadata_types branch July 12, 2023 09:08
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1505
https://xkcd.com/1505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants