Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forge std, git submodule command & nix flake for solidity compiler #1368

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

hellwolf
Copy link
Contributor

No description provided.

@hellwolf hellwolf requested a review from a team as a code owner April 20, 2023 16:01
@github-actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neato

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.60 🎉

Comparison is base (b2711c3) 88.23% compared to head (357af9d) 97.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1368      +/-   ##
==========================================
+ Coverage   88.23%   97.84%   +9.60%     
==========================================
  Files          86       38      -48     
  Lines        4311     2092    -2219     
  Branches      180        0     -180     
==========================================
- Hits         3804     2047    -1757     
+ Misses        463       45     -418     
+ Partials       44        0      -44     
Flag Coverage Δ
ethereum-contracts 97.84% <ø> (ø)
sdk-core ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 48 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hellwolf hellwolf merged commit 932e2e6 into dev Apr 21, 2023
@hellwolf hellwolf deleted the update_forge_std branch April 21, 2023 07:03
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1368
https://xkcd.com/1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants