-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROTOCOL-NG] Solidity Semantic Money draft release 1 #1280
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #1280 +/- ##
==========================================
+ Coverage 88.28% 97.94% +9.65%
==========================================
Files 86 38 -48
Lines 4311 2092 -2219
Branches 180 0 -180
==========================================
- Hits 3806 2049 -1757
+ Misses 461 43 -418
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/solidity-semantic-money/src/ref-impl/ISuperfluidPool.sol
Outdated
Show resolved
Hide resolved
If this got merged and used by the #1357 branch, let's merge so that GDA branch will be cleaner to maintain. I will do the a series of library explanation sessions as a separate and an ongoing process live. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XKCD Comic RelifLink: https://xkcd.com/1280 |
Background
This is the first release of the solidity semantic money library, used for building GDA in SuperToken v1 and SuperToken v2. The audience of this is the implementers of SuperTokens on any target system.
What's In the Bag
A Solidity library for building the general payment primitives aspect of the semantic money is ready:
SemanticMoney
.ToySuperToken
&TokenSuperfluidPool
, as reference implementation for GDA & SuperToken v2.Update the yellow paperdeferred to next PR.