calculateMaybeCriticalAtTimestamp is calculating for "insolvency time…

…" instead of "critical time" (#885) * removed deposit from critical timestamp calculation * edited variable name as per request * as per review comments * handled 1st case returing old maybe_critical_timestamp * use toBN() * as per comment * maybeCriticalAt should be initialized at null * updated test method * updated sdk core entity * added comment and throwing error * added comment and throwing error Co-authored-by: davinchee <0xdavinchee@gmail.com>
superfluid-finance · Jun 7, 2022 · 7dc62cd · 7dc62cd
1 parent ace5c31
commit 7dc62cd
Show file tree

Hide file tree

Showing 8 changed files with 61 additions and 190 deletions.
diff --git a/packages/sdk-core/src/subgraph/entities/accountTokenSnapshot/accountTokenSnapshot.ts b/packages/sdk-core/src/subgraph/entities/accountTokenSnapshot/accountTokenSnapshot.ts
@@ -31,7 +31,7 @@ export interface AccountTokenSnapshot {
     totalNetFlowRate: BigNumber;
     totalNumberOfActiveStreams: number;
     totalOutflowRate: BigNumber;
-    maybeCriticalAtTimestamp: Timestamp;
+    maybeCriticalAtTimestamp: Timestamp | null;
     isLiquidationEstimateOptimistic: boolean;
     totalNumberOfClosedStreams: number;
     totalSubscriptionsWithUnits: number;
@@ -76,7 +76,10 @@ export class AccountTokenSnapshotQueryHandler extends SubgraphQueryHandler<
             account: x.account.id,
             token: x.token.id,
             tokenSymbol: x.token.symbol,
-            maybeCriticalAtTimestamp: Number(x.maybeCriticalAtTimestamp),
+            maybeCriticalAtTimestamp:
+                x.maybeCriticalAtTimestamp != null
+                    ? Number(x.maybeCriticalAtTimestamp)
+                    : null,
             updatedAtBlockNumber: Number(x.updatedAtBlockNumber),
             updatedAtTimestamp: Number(x.updatedAtTimestamp),
         }));

diff --git a/packages/sdk-core/src/subgraph/entities/accountTokenSnapshotLog/accountTokenSnapshotLog.ts b/packages/sdk-core/src/subgraph/entities/accountTokenSnapshotLog/accountTokenSnapshotLog.ts
@@ -29,7 +29,7 @@ export interface AccountTokenSnapshotLog {
     timestamp: Timestamp;
     blockNumber: BlockNumber;
     balance: BigNumber;
-    maybeCriticalAtTimestamp: Timestamp;
+    maybeCriticalAtTimestamp: Timestamp | null;
     totalAmountStreamed: BigNumber;
     totalAmountTransferred: BigNumber;
     totalApprovedSubscriptions: number;
@@ -80,7 +80,10 @@ export class AccountTokenSnapshotLogQueryHandler extends SubgraphQueryHandler<
             account: x.account.id,
             token: x.token.id,
             tokenSymbol: x.token.symbol,
-            maybeCriticalAtTimestamp: Number(x.maybeCriticalAtTimestamp),
+            maybeCriticalAtTimestamp:
+                x.maybeCriticalAtTimestamp != null
+                    ? Number(x.maybeCriticalAtTimestamp)
+                    : null,
             blockNumber: Number(x.blockNumber),
             timestamp: Number(x.timestamp),
             order: Number(x.order),