Skip to content

Commit

Permalink
[ETHEREUM-CONTRACTS] 1.4.3 Release (#1158)
Browse files Browse the repository at this point in the history
* [JS-SDK] 再见 JS-SDK (#1072)

* Don't wrap SubgraphClient's errors with SFError (#1075)

* [SDK-CORE] 0.5.6 Patch Fix (#1074)

* fix subgraphAPIEndpoint for sdk-core

* Update constants.ts

* third time is the charm

* Update 5_subgraph.test.ts

* proper env variable name

* Update yarn.lock

* address comments

* isArbGoerli

* Get Nix Pilled (#1073)

* use nix flake to lock build toolchains such as yarn, foundry, ghc, etc.

* added nodejs 16 to dependencies

* add flakes/whitehat

* add flakes/whitehat

* devShells

* remove haskell tools

* [SDK-CORE] 0.5.6 Patch Fix (#1074)

* fix subgraphAPIEndpoint for sdk-core

* Update constants.ts

* third time is the charm

* Update 5_subgraph.test.ts

* proper env variable name

* Update yarn.lock

* address comments

* isArbGoerli

* updated contributing

* typo

Co-authored-by: 0xdavinchee <0xdavinchee@gmail.com>

* The Great TypeScript Refactor (#1069)

* TS WIP - testsuites

* tsconfig revamp
* convert testsuites files into TS
* fix up test:contracts:hardhat accordingly

* TS WIP - Typechain

* add typechain for ethereum-contracts

* TS WIP - UUPS and CallUtils

* convert UUPS test and CallUtils test file to typescript

* TS WIP - Utility Contract Tests

* convert utility contract tests to TypeScript
* remove file extension in all-contracts.ts
* add some helpers to helpers.js

* TS WIP - CFAv1Forwarder Tests

* convert CFAv1Forwarder contract tests to TypeScript

* TS WIP - Library Tests

* convert CFAv1Library and IDAv1Library contract tests to TypeScript

* TS WIP - Scenarios Tests

* convert scenarios tests to typescript

* TS WIP - Scenarios Tests

* convert scenarios tests to typescript

* TS WIP - SuperfluidGoverannceII tests

* convert SuperfluidGovernanceII contract tests to TypeScript

* TS WIP - Custom Tokens Tests

* convert custom token contract tests to TypeScript

* TS WIP - Superfluid Core Tests

* convert superfluid core tests to typescript
* use import instead of require in testsuite files

* TS WIP - Clean up commit pollution

* undo some of the variable renaming

* TS WIP - Clean up commit pollution (cont.)

* undo use of ethers over web3

* TS WIP - Clean up commit pollution (cont.)

* TS WIP - Token behavior files

* some cleanup
* mainly converted token behavior files

* TS WIP - CFA/IDA behavior files

* converted behavior files for CFA and IDA

* TS WIP - Convert peripheries

* convert CFADataModel, MFASupport, AgreementHelper, helpers, expectRevert to typescript

* TS WIP - Convert TestEnvironment

* convert TestEnvironment to typescript
* fix MFASupport import
* fix TestEnvironment imports
* remove module.exports from AgreementHelper

* TS WIP - Deprecate JS-SDK

remove js-sdk from:
- pr-artifact creation
- canary tests + coverage
- publish-pr-packages
- publish-release-packages
- codecov flag
- root package.json
- check-changeset.sh

* TS WIP - Add JS-SDK tests

* add tests that exist in js-sdk to sdk-core as part of deprecation

* TS WIP - Packages

* bump hardhat version
* lower js-sdk version

* TS WIP - Refactor Cleanup

* remove most explicit any's + add actual type
* separation of types from actual files in certain places where it is bloated
* BN refactor (passing in BigNumber to almost all funcs)
* .eslintrc.ts.json added to lint typescript test files
* lint fix files
* general type fixes

* remove parallel flag

* bump js-sdk version

* cleanup

* fix naming
* bump solidity-coverage version
* fix dead links

* Split cfa and ida test files

* split CFA and IDA test files into: callback vs non callback and mfa for cfa

* consistent file naming

* Bump terser in /packages/sdk-redux-examples/sdk-redux-react-typecript (#1078)

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](terser/terser@v4.8.0...v4.8.1)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [ETHEREUM-CONTRACTS] _isPatricianPeriod Patch (#1080)

* fix tests expect (#1082)

* this test just needs to know something is undefined
* in the workflow it lets us know which property is undefined, but locally it gives the original message: "Cannot read properties of undefined"

* further refactoring cleanup (#1081)

* use BigNumber almost everywhere
* use expect more
* remove js-sdk usage as much as possible
* remove web3 usage as much as possible

* [ETHEREUM-CONTRACTS] backport 1.4.1 fixes (#1084)

* [ETHEREUM-CONTRACTS] backport 1.4.1 fixes

- deployment scripts improvements
- [SECURITY] CFA: check flow sender instead of msg sender in order to cover ACL use

Co-authored-by: 0xdavinchee <0xdavinchee@gmail.com>

* fix build

fix build and add in patch fix test

* remove js and js-sdk

* fix imports

* purge js-sdk from readme.md

* just remove codecov badge

Co-authored-by: Didi <git@d10r.net>
Co-authored-by: 0xdavinchee <0xdavinchee@gmail.com>

* [JS-SDK] Half undo deprecation (#1098)

* Undo js-sdk deprecation

* half deprecate js-sdk

* remove JS-SDK from .github/workflows
* remove js-sdk from root level files
* fix undefined variable errors
* add JS-SDK test parity back in for SDK-Core
* tidy up README's
* remove build-abi-js.sh from bash files

* Update ci.feature.yml

* build!

* [ETHEREUM-CONTRACTS] CFAv1Forwarder Fixes (#1094)

* CFAV1Forwarder Fixes

* make _host and _cfa state variables immutable - these should not
* fix `_deleteFlow` logic
* fix natspec
* return true from _forwardBatchCall
* add comment about EIP 2771
* add CFAv1Forwarder tests
* add CFAv1Forwarder to deploy-framework + resolver

* require artifacts from hardhat

* pain

* use truffle build not hh artifacts

* hard code fix for now

* 👎

* undo js-sdk revert

* add CFAv1Forwader to js-sdk

* CFAv1Forwarder to js-sdk

* do this in a separate branch

* remove `protocolReleaseVersion`

* Fix links to the examples repo (#1100)

* [ETHEREUM-CONTRACTS] CFA Hooks (#1099)

* Fix subgraph testing: copy upstream docker compose file (#1109)

* [ETHEREUM-CONTRACTS] SuperfluidFrameworkDeployer Additions (#1104)

* Now SDK-CORE are testing using this deployer instead the web3-version of the deployer

* Update of the nix flake tooling (#1108)

* [ETHEREUM-CONTRACTS/SDK-CORE/SUBGRAPH] Use more Typechain capabilities (#1113)

Provide end-consumer access to typechain files via ethereum-contracts as the origin source and also exported via sdk-core
no more abi file imports, using typechain generated factories all around
fix up lint scripts
add typechain build pipeline in ethereum-contracts
Co-authored-by: Daniel <tokdaniel4@gmail.com>

* [ETHEREUM-CONTRACTS/SDK-CORE] CFAv1 Forwarder Integration (#1118)

* Agreement Forwarder Integration WIP

* Split supertoken tests into separate files
* Add CFAv1Forwarder to SuperfluidFrameworkDeployer + set in resolver and enable as trusted forwarder
* Integrate CFAv1Forwarder in SDK-Core
* tests to ensure that forwarder is being used and works as expected
* validateOperationShouldUseCallAgreement checks that we are using agreement forwarder

* Update CHANGELOG.md

* SDK-Core cleanup

Co-Authored-By: tokdaniel <7677603+tokdaniel@users.noreply.github.com>

* Fix them hardcoded addresses!

* two step fix

* Subgraph test setup cleanup

* delete test-subgraph.template, it is a duplicate
* rename prepare-local: prepare-manifest-local
* update ganache.json
* create runDeployContractsAndToken.ts to deploy framework and tokens and create new ganache.json dynamically
* no more hardcoded addresses in addresses.template.ts!
* helpers.ts modified to read ganache.json file to retrieve resolver address to setup framework

* must build sdk-core

* Fixes

* Make it properly dynamic by deploying and preparing local files prior to actual subgraph deployment
* fix up package.json given the above
* fix up readme

* build sdk-core before deploy contracts

* do not redeploy

* missed the other reusable workflow

* chainId unddefined?

* sender is not needed here

Co-authored-by: tokdaniel <7677603+tokdaniel@users.noreply.github.com>

* [ETHEREUM-CONTRACTS/SDK-CORE] Ethereum-Contracts 1.4.2 / SDK-Core 0.5.7 (#1119)

* bump sdk-core version

* update metadata for satsuma endpoint

* bump eth-contracts + changelog

* [SUBGRAPH] graph-node issue resolved by The Graph team (#1130)

pinned to 0.28.1: graphprotocol/graph-node#4034

* [SUBGRAPH] Revert Changes + Cleanup (#1131)

* Update Codeowners (#1132)

* Update Codeowners
- adding 0xdavinchee as co-codeowner of /packages/ethereum-contracts/
- adding @kasparkallas to js-sdk too as SDK co-owners.

* [SDK-CORE] Gas Multiplier (#1128)

* gas multiplier
* fix where we handle the gasLimit
* handle the gas limit modification one level deeper to not break other SDK-Core functionality
* address review comments

* [CI/SUBGRAPH] Workflow + Script for deploying to Satsuma endpoint (#1125)

* modify deploy-subgraph.yml
- modify workflow for deploy-subgraph to support new deploy-to-satsuma.sh bash script
* ci workflow cleanup
* Update handler.deploy-subgraph.yml
* address review comments

* [ETHEREUM-CONTRACTS] Hardcoded Hook Gas Limit (#1129)

* add option for CFA hook to deploy script
* hardcode `CFA_HOOK_GAS_LIMIT`
* test case added
* fix deployment test
* handle the magical 1/64 case
* blow up in catch
* fix deployment script
* simplification: make hook gas limit a constant
* fix flakey foundry invariant test
* the clipped deposits need to be bounded appropriately
* no mentions
* comment cleanup

Co-authored-by: didi <git@d10r.net>

* [SDK-CORE] Load w/ metadata (#1127)

* sdk-core load w/ metadata
* install graphql
* changelog + ethers mentioned
* address comments
* no more EMPTY_NETWORK_DATA

* Yellowpaper 1 - Denotational Semantics of General Payment Primitives, and Its Payment System (#1105)

* [CI] Changelog reminder handler (#1133)

* create changelog reminder handler
* changlog reminder handler
* cleanup of check-changeset.sh
* forgot to checkout monorepo
* bad syntax

Co-authored-by: Miao ZhiCheng <miao@superfluid.finance>

* CFA forwarder deployment related changes (#1117)

* improved tooling for same-address deployment of CFA forwarder

* ISSUE #1089 - Create2 Hybrid SuperTokenFactory (#1115)

* Contracts WIP

* `createCanonicalERC20Wrapper` and `computeWrapperSuperTokenAddress` implemented
* both functions added to `ISuperTokenFactory`

* canonical creation tests

* tests that compute works as expected
* tests create2 works as expected
* tests that we can only create canonical token once
* tests that we can create canonical erc20 wrappers for multiple tokens

* initialize list

* implementation for list initialization added
* tests added for list initialization

* fix flakey foundry invariant test

* the clipped deposits need to be bounded appropriately

* address review comments

* rename computeWrapperSuperTokenAddress to computeCanonicalERC20WrapperAddress
* fix up comments
* add new custom error code
* add getCanonicalERC20Wrapper function

* Address Review Comments

* Add warning about reordering storage layouts in all contracts which have upgradability
* Add note comments about adding tests to validateStorageLayout if proxy contract storage layout is touched
* Fix up tests given review comment logic changes

* typo fix

* address review comments

* add to readme
* remove "our" from vocabulary when referring to canonical erc20 wrapper list
* use ownable over SueprfluidGovernanceII

* remove InitializeData from ISuperTokenFactory.sol

* Remove SuperfluidErrors Library (#1142)

* Localize custom errors to individual contracts
* Modify tests accordingly
* Retain the name so that it is easy to debug which contract is throwing the error
* No more use of error codes as this is redundant given the above
* Comments with the hashed custom error name for quick debugging

* [SUBGRAPH] Event Entity Base Property Initialization Refactor (#1143)

* simple refactoring

* utilize entity.set in initializeEventEntity to cut down on code and duplication

* no upcast - must pass entity

* bad copy paste

* set non null account entity!

* review comments addressed!

* [ETHEREUM-CONTRACTS/JS-SDK] Contracts scripts typings + JS-SDK cleanup (#1144)

* Map deposit from Subgraph to Stream (#1145)

Co-authored-by: Miao ZhiCheng <miao@superfluid.finance>

* Yellowpaper v1.0: errata and grammatic fixes after reviews (#1148)

* [SDK-CORE/SDK-REDUX] Fix reference docs Cloudfront bucket ID & use single "@dev" for latest dev-build (#1146)

* Use new cloudfront distribution ID
* Use single dev-version instead of many specific dev-versions for ref docs

* Update sdk-redux dependencies and bump version (#1147)

* Bump apollo-server-core from 3.10.0 to 3.11.0 (#1149)

Bumps [apollo-server-core](https://github.com/apollographql/apollo-server/tree/HEAD/packages/apollo-server-core) from 3.10.0 to 3.11.0.
- [Release notes](https://github.com/apollographql/apollo-server/releases)
- [Changelog](https://github.com/apollographql/apollo-server/blob/apollo-server-core@3.11.0/CHANGELOG.md)
- [Commits](https://github.com/apollographql/apollo-server/commits/apollo-server-core@3.11.0/packages/apollo-server-core)

---
updated-dependencies:
- dependency-name: apollo-server-core
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [SDK-CORE] Mainnet Support | TODO: Reinstall @superfluid-finance/metadata (#1139)

* add mainnet to relevant workflow files (#1141)

Co-authored-by: Didi <git@d10r.net>

* [SUBGRAPH] Mainnet Support (#1140)

Co-authored-by: Didi <github@d10r.net>

* TOGAv3: use transfer and eliminate custodian - signed (#1150)

* minor cleanups

* remove .ts script file which broke the build

* undo yarn.lock

* fix tests

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance>
Co-authored-by: Miao ZhiCheng <miao@superfluid.finance>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Didi <git@d10r.net>
Co-authored-by: sffn3va <114768934+sffn3va@users.noreply.github.com>
Co-authored-by: tokdaniel <7677603+tokdaniel@users.noreply.github.com>
Co-authored-by: Didi <github@d10r.net>
  • Loading branch information
8 people authored Nov 14, 2022
1 parent b682ca2 commit 4739f1e
Show file tree
Hide file tree
Showing 168 changed files with 3,989 additions and 2,300 deletions.
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@ indent_size = 2

[*.yaml]
indent_size = 2

[*.nix]
indent_style = 2
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,6 @@ jobs:
run: yarn prepare-local
working-directory: ./packages/subgraph

- name: "Deploy Framework and Tokens"
run: npx hardhat run scripts/runDeployContractsAndToken.ts --network localhost
working-directory: ./packages/subgraph

- name: "Prepare files for local testing"
run: yarn prepare-local
working-directory: ./packages/subgraph

- name: "Run setup-graph-node"
run: |
chmod +x ./tasks/setup-graph-node.sh
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ jobs:
aws_region: eu-west-2
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}sdk-core@{1}', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI, steps.sdk-versions.outputs.SDK_CORE_VERSION) }}
cloudfront_distribution_id: E3SV855CTC9UJO
s3_uri: ${{ format('{0}sdk-core@dev', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI) }}
cloudfront_distribution_id: E3JEO5R14CT8IH

- name: Upload sdk-redux HTML documentation
uses: ./build-scripts/s3cloudfront-hosting/actions/sync
Expand All @@ -254,8 +254,8 @@ jobs:
aws_region: eu-west-2
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}sdk-redux@{1}', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI, steps.sdk-versions.outputs.SDK_REDUX_VERSION) }}
cloudfront_distribution_id: E3SV855CTC9UJO
s3_uri: ${{ format('{0}sdk-redux@dev', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI) }}
cloudfront_distribution_id: E3JEO5R14CT8IH

upgrade-contracts:
name: Upgrade ethereum-contracts on goerli testnet (protocol release version "test")
Expand Down
44 changes: 44 additions & 0 deletions .github/workflows/handler.changelog-reminder.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Changelog Reminder

on:
pull_request:
types: [opened]

jobs:
check:
name: Check which packages have been modified

runs-on: ubuntu-latest

outputs:
build_ethereum_contracts: ${{ env.BUILD_ETHEREUM_CONTRACTS }}
build_sdk_core: ${{ env.BUILD_SDK_CORE }}
build_sdk_redux: ${{ env.BUILD_SDK_REDUX }}
build_spec_haskell: ${{ env.BUILD_SPEC_HASKELL }}

steps:
- uses: actions/checkout@v3

- name: Check changeset
run: tasks/check-changeset.sh ${{ github.sha }} dev

create-reminder:
name: Create Changelog reminder in PR discussion

runs-on: ubuntu-latest

needs: [check]
if: needs.check.outputs.build_ethereum_contracts || needs.check.outputs.build_sdk_core || needs.check.outputs.build_sdk_redux || needs.check.outputs.build_spec_haskell

steps:
- name: Create Reminder
uses: peter-evans/create-or-update-comment@v2
with:
issue-number: ${{ github.event.pull_request.number }}
body: |
## Changelog Reminder
Reminder to update the CHANGELOG.md for any of the modified packages in this PR.
- [ ] CHANGELOG.md modified
- [ ] Double check before merge
reactions: white_check_mark
22 changes: 20 additions & 2 deletions .github/workflows/handler.deploy-subgraph.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,20 @@ on:
release_branch:
description: 'Release branch (feature/dev/v1...)'
required: true
type: string
default: 'feature'
deploy_to_satsuma_endpoint:
required: true
type: boolean
description: "Explicitly declare whether you want to deploy to Satsuma's endpoint."
network:
required: false
type: string
description: 'Network to deploy to (matic/xdai/kovan...)'
satsuma_version_label:
required: false
type: string
description: 'Version label for Satsuma deployment, we are not using this for hosted deployments (format: v0.0.1)'

jobs:
deploy-subgraph:
Expand Down Expand Up @@ -58,8 +68,16 @@ jobs:
run: "yarn codegen"
working-directory: ${{ env.subgraph-working-directory }}

- name: "Deploy to endpoint"
- name: "Deploy to Satsuma endpoint"
if: inputs.deploy_to_satsuma_endpoint == true
run: "yarn deploy:to-satsuma ${{ github.event.inputs.satsuma_version_label }} ${{ github.event.inputs.network }}"
working-directory: ${{ env.subgraph-working-directory }}
env:
SATSUMA_DEPLOY_KEY: ${{ secrets.SATSUMA_DEPLOY_KEY }}

- name: "Deploy to Hosted Subgraph Superfluid endpoint"
if: inputs.deploy_to_satsuma_endpoint == false
run: "yarn deploy ${{ github.event.inputs.release_branch }} ${{ github.event.inputs.network }}"
working-directory: ${{ env.subgraph-working-directory }}
env:
THEGRAPH_ACCESS_TOKEN: ${{ secrets.THEGRAPH_ACCESS_TOKEN }}
THE_GRAPH_ACCESS_TOKEN: ${{ secrets.THE_GRAPH_ACCESS_TOKEN }}
3 changes: 2 additions & 1 deletion .github/workflows/handler.deploy-to-mainnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
# testnet web3 providers (leaving for testing)
AVALANCHE_FUJI_PROVIDER_URL: ${{ secrets.AVALANCHE_FUJI_PROVIDER_URL }}
# mainnet web3 providers
ETH_MAINNET_PROVIDER_URL: ${{ secrets.ETH_MAINNET_PROVIDER_URL }}
XDAI_MAINNET_PROVIDER_URL: ${{ secrets.XDAI_MAINNET_PROVIDER_URL }}
POLYGON_MAINNET_PROVIDER_URL: ${{ secrets.POLYGON_MAINNET_PROVIDER_URL }}
OPTIMISM_MAINNET_PROVIDER_URL: ${{ secrets.OPTIMISM_MAINNET_PROVIDER_URL }}
Expand Down Expand Up @@ -71,4 +72,4 @@ jobs:
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}{1}-contract-addrs@{2}', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI, github.event.inputs.network, github.run_id) }}
cloudfront_distribution_id: E3SV855CTC9UJO
cloudfront_distribution_id: E3JEO5R14CT8IH
14 changes: 8 additions & 6 deletions .github/workflows/handler.list-super-token.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,16 @@ jobs:
env:
DEFAULT_MNEMONIC: ${{ secrets.BUILD_AGENT_MNEMONIC }}
# network web3 providers
ETH_GOERLI_PROVIDER_URL: ${{ secrets.ETH_GOERLI_PROVIDER_URL }}
POLYGON_MUMBAI_PROVIDER_URL: ${{ secrets.POLYGON_MUMBAI_PROVIDER_URL }}
ETH_MAINNET_PROVIDER_URL: ${{ secrets.ETH_MAINNET_PROVIDER_URL }}
XDAI_MAINNET_PROVIDER_URL: ${{ secrets.XDAI_MAINNET_PROVIDER_URL }}
POLYGON_MAINNET_PROVIDER_URL: ${{ secrets.POLYGON_MAINNET_PROVIDER_URL }}
OPTIMISM_GOERLI_PROVIDER_URL: ${{ secrets.OPTIMISM_GOERLI_PROVIDER_URL }}
ARBITRUM_GOERLI_PROVIDER_URL: ${{ secrets.ARBITRUM_GOERLI_PROVIDER_URL }}
AVALANCHE_FUJI_PROVIDER_URL: ${{ secrets.AVALANCHE_FUJI_PROVIDER_URL }}
OPTIMISM_MAINNET_PROVIDER_URL: ${{ secrets.OPTIMISM_MAINNET_PROVIDER_URL }}
ARBITRUM_ONE_PROVIDER_URL: ${{ secrets.ARBITRUM_ONE_PROVIDER_URL }}
AVALANCHE_C_PROVIDER_URL: ${{ secrets.AVALANCHE_C_PROVIDER_URL }}
BSC_MAINNET_PROVIDER_URL: ${{ secrets.BSC_MAINNET_PROVIDER_URL }}
AVALANCHE_C_PROVIDER_URL: ${{ secrets.AVALANCHE_C_PROVIDER_URL }}

OPTIMISM_GOERLI_PROVIDER_URL: ${{ secrets.OPTIMISM_GOERLI_PROVIDER_URL }}
ARBITRUM_GOERLI_PROVIDER_URL: ${{ secrets.ARBITRUM_GOERLI_PROVIDER_URL }}
ETH_GOERLI_PROVIDER_URL: ${{ secrets.ETH_GOERLI_PROVIDER_URL }}
POLYGON_MUMBAI_PROVIDER_URL: ${{ secrets.POLYGON_MUMBAI_PROVIDER_URL }}
AVALANCHE_FUJI_PROVIDER_URL: ${{ secrets.AVALANCHE_FUJI_PROVIDER_URL }}
8 changes: 4 additions & 4 deletions .github/workflows/handler.publish-release-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}sdk-core@{1}', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI, steps.publish-sdk-core.outputs.PUBLISHED_VERSION) }}
cloudfront_distribution_id: E3SV855CTC9UJO
cloudfront_distribution_id: E3JEO5R14CT8IH

- name: Upload sdk-core latest documentation redirect
if: env.PUBLISH_SDK_CORE == 1
Expand All @@ -90,7 +90,7 @@ jobs:
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}sdk-core', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI) }}
cloudfront_distribution_id: E3SV855CTC9UJO
cloudfront_distribution_id: E3JEO5R14CT8IH

- name: Publish sdk-redux package
id: publish-sdk-redux
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}sdk-redux@{1}', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI, steps.publish-sdk-redux.outputs.PUBLISHED_VERSION) }}
cloudfront_distribution_id: E3SV855CTC9UJO
cloudfront_distribution_id: E3JEO5R14CT8IH

- name: Upload sdk-redux latest documentation redirect
if: env.PUBLISH_SDK_REDUX == 1
Expand All @@ -131,4 +131,4 @@ jobs:
aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
s3_uri: ${{ format('{0}sdk-redux', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI) }}
cloudfront_distribution_id: E3SV855CTC9UJO
cloudfront_distribution_id: E3JEO5R14CT8IH
14 changes: 8 additions & 6 deletions .github/workflows/handler.run-ethereum-contracts-script.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,16 @@ jobs:

DEFAULT_MNEMONIC: ${{ secrets.BUILD_AGENT_MNEMONIC }}
# network web3 providers
ETH_GOERLI_PROVIDER_URL: ${{ secrets.ETH_GOERLI_PROVIDER_URL }}
POLYGON_MUMBAI_PROVIDER_URL: ${{ secrets.POLYGON_MUMBAI_PROVIDER_URL }}
ETH_MAINNET_PROVIDER_URL: ${{ secrets.ETH_MAINNET_PROVIDER_URL }}
XDAI_MAINNET_PROVIDER_URL: ${{ secrets.XDAI_MAINNET_PROVIDER_URL }}
POLYGON_MAINNET_PROVIDER_URL: ${{ secrets.POLYGON_MAINNET_PROVIDER_URL }}
OPTIMISM_GOERLI_PROVIDER_URL: ${{ secrets.OPTIMISM_GOERLI_PROVIDER_URL }}
ARBITRUM_GOERLI_PROVIDER_URL: ${{ secrets.ARBITRUM_GOERLI_PROVIDER_URL }}
AVALANCHE_FUJI_PROVIDER_URL: ${{ secrets.AVALANCHE_FUJI_PROVIDER_URL }}
OPTIMISM_MAINNET_PROVIDER_URL: ${{ secrets.OPTIMISM_MAINNET_PROVIDER_URL }}
ARBITRUM_ONE_PROVIDER_URL: ${{ secrets.ARBITRUM_ONE_PROVIDER_URL }}
AVALANCHE_C_PROVIDER_URL: ${{ secrets.AVALANCHE_C_PROVIDER_URL }}
BSC_MAINNET_PROVIDER_URL: ${{ secrets.BSC_MAINNET_PROVIDER_URL }}
AVALANCHE_C_PROVIDER_URL: ${{ secrets.AVALANCHE_C_PROVIDER_URL }}

OPTIMISM_GOERLI_PROVIDER_URL: ${{ secrets.OPTIMISM_GOERLI_PROVIDER_URL }}
ARBITRUM_GOERLI_PROVIDER_URL: ${{ secrets.ARBITRUM_GOERLI_PROVIDER_URL }}
ETH_GOERLI_PROVIDER_URL: ${{ secrets.ETH_GOERLI_PROVIDER_URL }}
POLYGON_MUMBAI_PROVIDER_URL: ${{ secrets.POLYGON_MUMBAI_PROVIDER_URL }}
AVALANCHE_FUJI_PROVIDER_URL: ${{ secrets.AVALANCHE_FUJI_PROVIDER_URL }}
2 changes: 1 addition & 1 deletion .github/workflows/handler.update-evm-contracts-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
# aws_access_key_id: ${{ secrets.SITE_DEPLOYER_AWS_ACCESS_KEY_ID }}
# aws_secret_access_key: ${{ secrets.SITE_DEPLOYER_AWS_SECRET_ACCESS_KEY }}
# s3_uri: ${{ format('{0}ethereum-contracts@{1}', secrets.SITE_DEPLOYER_AWS_S3_DOCS_URI, steps.sdk-versions.outputs.CONTRACTS_VERSION) }}
# cloudfront_distribution_id: E3SV855CTC9UJO
# cloudfront_distribution_id: E3JEO5R14CT8IH

- name: Update the docs repo
uses: dmnemec/copy_file_to_another_repo_action@main
Expand Down
8 changes: 4 additions & 4 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# REFERENCE: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# By default no owner, so everyone in the FTE team can approve the pull request
* @superfluid-finance/fte
# By default no owner, so everyone in the protocal devs group can approve the pull request
* @superfluid-finance/protocol-devs

# Workflow files are gatekept by MiaoZC
/.github/ @hellwolf
Expand All @@ -11,8 +11,8 @@
# Packages
#
/packages/spec-haskell/ @hellwolf
/packages/ethereum-contracts/ @hellwolf
/packages/js-sdk/ @hellwolf @0xdavinchee
/packages/ethereum-contracts/ @hellwolf @0xdavinchee
/packages/js-sdk/ @hellwolf @kasparkallas @0xdavinchee
/packages/subgraph/ @0xdavinchee @kasparkallas @hellwolf
/packages/sdk-core/ @0xdavinchee @kasparkallas @hellwolf
/packages/sdk-redux/ @0xdavinchee @kasparkallas @hellwolf
Expand Down
12 changes: 6 additions & 6 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
supportedGhcVersions = [ "924" ];
})
hlint
stylish-haskell
gnuplot
# sage math
sage
Expand Down
4 changes: 3 additions & 1 deletion packages/ethereum-contracts/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@
/artifacts
/cache
/docs/api
/typechain-types
/typechain-types
/scripts/**/*.d.ts
/scripts/**/*.d.ts.map
10 changes: 10 additions & 0 deletions packages/ethereum-contracts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## Unreleased

## [v1.4.3] - 2022-11-14
### Added

- `createCanonicalERC20Wrapper` added for creating ERC20 Wrapper Super tokens which will be added to a canonical wrapper super token list based on naming convention and semi-upgradeability. This will be the recommended way of creating ERC20 Wrapper moving forward. (#1115)
- `name` naming convention: Super Token `name` will be `"Super ${underlyingToken.name}"`
- `symbol` naming convention: Super Token `symbol` will be `"${underlyingToken.symbol}x"`
- Hardhat `artifacts` included in npm package (#1144)
- Include declaration files in `types` folder for files in `scripts` in npm package (#1144)
- Remove custom error codes in favor of localized per contract custom errors (#1142)

## [v.1.4.2] - 2022-10-13
### Added

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ pragma solidity 0.8.16;

import { UUPSProxiable } from "../upgradability/UUPSProxiable.sol";
import { ISuperAgreement } from "../interfaces/superfluid/ISuperAgreement.sol";
import { SuperfluidErrors } from "../interfaces/superfluid/Definitions.sol";

/**
* @title Superfluid agreement base boilerplate contract
Expand All @@ -15,6 +14,9 @@ abstract contract AgreementBase is
{
address immutable internal _host;

// Custom Erorrs
error AGREEMENT_BASE_ONLY_HOST(); // 0x1601d91e

constructor(address host)
{
_host = host;
Expand All @@ -30,7 +32,7 @@ abstract contract AgreementBase is
function updateCode(address newAddress)
external override
{
if (msg.sender != _host) revert SuperfluidErrors.ONLY_HOST(SuperfluidErrors.AGREEMENT_BASE_ONLY_HOST);
if (msg.sender != _host) revert AGREEMENT_BASE_ONLY_HOST();
return _updateCodeAddress(newAddress);
}

Expand Down
Loading

0 comments on commit 4739f1e

Please sign in to comment.