Skip to content

fix: close toolbar dropdowns when clicking in editor area #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gpardhivvarma wants to merge 1 commit into from
Closed

fix: close toolbar dropdowns when clicking in editor area #2170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/super-editor/src/components/toolbar/ButtonGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup>
import { computed, ref, h } from 'vue';
import { computed, ref, h, onMounted, onBeforeUnmount } from 'vue';
import ToolbarButton from './ToolbarButton.vue';
import ToolbarSeparator from './ToolbarSeparator.vue';
import OverflowMenu from './OverflowMenu.vue';
Expand Down Expand Up @@ -204,6 +204,21 @@ const handleFocus = (e) => {
}
};

const handleDocumentPointerDown = (event) => {
if (!currentItem.value?.expand) return;
const target = event.target;
if (target?.closest?.('[data-editor-ui-surface]') || target?.closest?.('.n-dropdown')) return;
closeDropdowns();
};

onMounted(() => {
document.addEventListener('pointerdown', handleDocumentPointerDown, true);
});

onBeforeUnmount(() => {
document.removeEventListener('pointerdown', handleDocumentPointerDown, true);
});

const handleDropdownUpdateShow = (open) => {
if (!open) {
closeDropdowns();
Expand Down