Skip to content

fix: preserve selection highlight when opening toolbar dropdowns (SD-1905) #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 1 commit into from
Feb 18, 2026
Merged

fix: preserve selection highlight when opening toolbar dropdowns (SD-1905) #2097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/super-editor/src/core/presentation-editor/PresentationEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3662,7 +3662,13 @@ export class PresentationEditor extends EventEmitter {
// Keep selection visible when context menu (SlashMenu) is open
const slashMenuOpen = activeEditor?.state ? !!SlashMenuPluginKey.getState(activeEditor.state)?.open : false;

if (!hasFocus && !slashMenuOpen) {
// Keep selection visible when focus is on editor UI surfaces (toolbar, dropdowns).
// Naive-UI portals dropdown content under .v-binder-follower-content at <body> level,
// so it won't be inside [data-editor-ui-surface]. Check both.
const activeEl = document.activeElement;
const isOnEditorUi = !!(activeEl as Element)?.closest?.('[data-editor-ui-surface], .v-binder-follower-content');

if (!hasFocus && !slashMenuOpen && !isOnEditorUi) {
try {
this.#clearSelectedFieldAnnotationClass();
this.#localSelectionLayer.innerHTML = '';
Expand Down
48 changes: 48 additions & 0 deletions ...visual/tests/behavior/basic-commands/sd-1905-selection-highlight-toolbar-dropdown.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import { test, expect } from '../../fixtures/superdoc.js';

test.use({ config: { hideSelection: false } });

test('@behavior SD-1905 selection highlight preserved when focus moves to editor UI surface', async ({ superdoc }) => {
await superdoc.type('Select this text then open dropdown');
await superdoc.waitForStable();

// Select all text via keyboard shortcut
await superdoc.selectAll();
await superdoc.waitForStable();

// Verify selection overlay is rendered
const overlayChildCount = await superdoc.page.evaluate(() => {
const overlay = document.querySelector('.presentation-editor__selection-layer--local');
return overlay ? overlay.children.length : -1;
});
expect(overlayChildCount).toBeGreaterThan(0);

await superdoc.screenshot('sd-1905-selection-before-ui-focus');

// Simulate focus moving to an editor UI surface (e.g. toolbar dropdown).
// This is what happens when a user clicks a toolbar dropdown — focus leaves
// the ProseMirror editor and moves to a UI element marked as editor UI.
await superdoc.page.evaluate(() => {
const btn = document.createElement('button');
btn.setAttribute('data-editor-ui-surface', '');
btn.textContent = 'Fake toolbar button';
btn.id = 'sd-1905-test-ui-surface';
document.body.appendChild(btn);
btn.focus();
});
await superdoc.waitForStable();

// Selection overlay should still be visible after focus moved to UI surface
const overlayAfterUiFocus = await superdoc.page.evaluate(() => {
const overlay = document.querySelector('.presentation-editor__selection-layer--local');
return overlay ? overlay.children.length : -1;
});
expect(overlayAfterUiFocus).toBeGreaterThan(0);

await superdoc.screenshot('sd-1905-selection-with-ui-surface-focused');

// Clean up test element
await superdoc.page.evaluate(() => {
document.getElementById('sd-1905-test-ui-surface')?.remove();
});
});
Loading