Skip to content

fix: correctly pass table info when deriving inline run properties (SD-1865)#2007

Merged
harbournick merged 6 commits intomainfrom
luccas/sd-1865-bug-document-text-displays-incorrect-formatting
Feb 16, 2026
Merged

fix: correctly pass table info when deriving inline run properties (SD-1865)#2007
harbournick merged 6 commits intomainfrom
luccas/sd-1865-bug-document-text-displays-incorrect-formatting

Conversation

@luccas-harbour
Copy link
Contributor

@luccas-harbour luccas-harbour commented Feb 12, 2026

  • There was a bug during the computation of inline run properties where a parameter with information about a run's parent table wasn't passed. This made subsequent parameters get shifted, causing incorrect calculations for some documents.
  • This was fixed and table information is now being extracted and used for computing properties.
  • There was also an issue where table/list information was not correctly passed when splitting a run. This was also fixed.
  • And finally, some type definitions for the style resolution functions were outdated. These were fixed.

@linear
Copy link

linear bot commented Feb 12, 2026

@luccas-harbour luccas-harbour changed the title fix: pass table info when deriving inline run properties fix: correctly pass table info when deriving inline run properties (SD-1865) Feb 12, 2026
@luccas-harbour luccas-harbour marked this pull request as ready for review February 12, 2026 13:58
@luccas-harbour luccas-harbour marked this pull request as draft February 12, 2026 14:02
@luccas-harbour luccas-harbour force-pushed the luccas/sd-1865-bug-document-text-displays-incorrect-formatting branch 2 times, most recently from b8989ea to 6557a44 Compare February 12, 2026 16:03
@luccas-harbour luccas-harbour marked this pull request as ready for review February 12, 2026 16:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6557a4498c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@luccas-harbour luccas-harbour force-pushed the luccas/sd-1865-bug-document-text-displays-incorrect-formatting branch from 6557a44 to f40a171 Compare February 12, 2026 16:43
@harbournick harbournick added the don't merge Don't merge yet label Feb 14, 2026
@github-actions
Copy link
Contributor

⚠️ AI Risk Review — potential issues found

  • In the shown OLD version of calculateInlineRunPropertiesPlugin.js (line 210-219), resolveRunProperties is called with 5 parameters where the 4th is false (intended as isListNumber), but the new signature expects tableInfo as 4th param—this causes boolean false to be interpreted as tableInfo=null (correct by accident) but shifts isListNumber/numberingDefinedInline arguments by one position, potentially causing list numbering bugs

Via L3 deep analysis · critical risk

Copy link
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Visual diffs detected

Pixel differences were found in visual tests. This is not blocking — reproduce locally with cd tests/visual && pnpm docs:download && pnpm test to review diffs.

@harbournick harbournick merged commit d752aff into main Feb 16, 2026
6 checks passed
@harbournick harbournick deleted the luccas/sd-1865-bug-document-text-displays-incorrect-formatting branch February 16, 2026 21:53
@superdoc-bot
Copy link
Contributor

superdoc-bot bot commented Feb 16, 2026

🎉 This PR is included in superdoc v1.14.0-next.2

The release is available on GitHub release

harbournick pushed a commit that referenced this pull request Feb 17, 2026
# [1.14.0](v1.13.1...v1.14.0) (2026-02-17)

### Bug Fixes

* **build:** remove dead vite-plugin-node-polyfills from UMD externals ([91de1fc](91de1fc))
* **converter:** handle empty rPrChange run properties without dropping tracked-style runs ([c25d24d](c25d24d))
* correctly pass table info when deriving inline run properties (SD-1865) ([#2007](#2007)) ([d752aff](d752aff))
* replace Node.js Buffer APIs with browser-native alternatives ([#2028](#2028)) ([b17774a](b17774a)), closes [#exportProcessMediaFiles](https://github.com/superdoc-dev/superdoc/issues/exportProcessMediaFiles)
* **tracked-changes:** colors should be restored when format rejected ([#1970](#1970)) ([01ea504](01ea504))

### Features

* add pdf infra, migrate layers ([#2078](#2078)) ([7d416e9](7d416e9))
* layout snapshot testing ([#2035](#2035)) ([b070cd7](b070cd7))
@harbournick
Copy link
Collaborator

🎉 This PR is included in superdoc v1.14.0

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants