fix: normalize bookmarks in tables#1892
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f6ac31816
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Outdated
Show resolved
Hide resolved
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
looks good overall! just a minor comment
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.test.js
Show resolved
Hide resolved
… sd-1681_block-id-crash
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@caio-pizzol please let me know If I have to do something with the last spec review. https://ooxml.dev/ page 900 tells that colFirst/colLast are valid attributes for bookmarkStart |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
nice work on the latest round -- colFirst/colLast, the JSDoc, dead ternary, and findTextblockIndex extraction all look good. three minor quality things left below.
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.test.js
Show resolved
Hide resolved
Visual diffs detectedPixel differences were found in visual tests. This is not blocking — reproduce locally with |
|
🎉 This PR is included in superdoc v1.13.0-next.6 The release is available on GitHub release |
# [1.13.0](v1.12.0...v1.13.0) (2026-02-14) ### Bug Fixes * anchor table overlaps text ([#1995](#1995)) ([fc05e29](fc05e29)) * collaboration cursor styles fix ([fd6db10](fd6db10)) * ensure we do not duplicate bubble text ([#1934](#1934)) ([c41cf9e](c41cf9e)) * ignore sdBlockId when pasting content ([#2010](#2010)) ([1b08572](1b08572)) * normalize bookmarks in tables ([#1892](#1892)) ([369b7e1](369b7e1)) * replace Node.js Buffer APIs with browser-native alternatives ([#2028](#2028)) ([b17774a](b17774a)), closes [#exportProcessMediaFiles](https://github.com/superdoc-dev/superdoc/issues/exportProcessMediaFiles) * use correct template syntax for GitHub release URL in PR comments ([9d1bca2](9d1bca2)) ### Features * enabled telemetry by default and added documentation ([#2001](#2001)) ([8598ef7](8598ef7)) * enhance telemetry handling for sub-editors ([#2017](#2017)) ([37bc030](37bc030)) * update telemetry configuration to prioritize root licenseKey ([#2016](#2016)) ([3b4ff6b](3b4ff6b))
|
🎉 This PR is included in superdoc v1.13.0 The release is available on GitHub release |
4 participants
No description provided.