Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for shortcut buttons (#4606) #4608

Closed
wants to merge 2 commits into from
Closed

Fix logic for shortcut buttons (#4606) #4608

wants to merge 2 commits into from

Conversation

thecalcc
Copy link
Contributor

SDCP-809

@thecalcc thecalcc changed the base branch from develop to release/2.7 August 21, 2024 07:58
@petrjasek
Copy link
Member

it's better to cherry-pick it and push it there so when we merge the branch later back to develop there won't be conflicts

@thecalcc thecalcc changed the base branch from release/2.7 to backport-shortcuts-2.7 August 21, 2024 08:50
@thecalcc
Copy link
Contributor Author

@petrjasek CI failing here, you did make some fixes yesterday to that right? i wonder if backporting them here as well would do the job

@petrjasek
Copy link
Member

let me check, but those errors are different

@petrjasek petrjasek mentioned this pull request Aug 22, 2024
Merged
@thecalcc thecalcc closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrjasek petrjasek petrjasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @petrjasek