Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display dropzone for article embeds dropping #4413

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Display dropzone for article embeds dropping #4413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e60a85
Display dropzone for article embeds dropping
thecalcc Jan 11, 2024
5d88a49
Add comment
thecalcc Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/core/editor3/components/Editor3Component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@
...MEDIA_TYPES_TRIGGER_DROP_ZONE,
EDITOR_BLOCK_TYPE,
'Files',

// allows dropping marked links as embeds (used by ansa)
'application/superdesk.compatible.embed',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to describe how this works and link to the line that handles dropped embeds

];

const VALID_MEDIA_TYPES = [
Expand Down Expand Up @@ -533,7 +536,7 @@
// eslint-disable-next-line react/no-find-dom-node
this.editorNode.current = this.editor === null ?
undefined :
ReactDOM.findDOMNode(this.editor) as HTMLDivElement;

Check warning on line 539 in scripts/core/editor3/components/Editor3Component.tsx

View workflow job for this annotation

GitHub Actions / test 

Do not use findDOMNode
}

componentWillUnmount() {
Expand Down
Loading