focus first input when opening authoring #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecalcc
approved these changes
Oct 27, 2023
|
I've pulled this down into my dev environment and I'm not convinced it works, querySelectorAll doesn't find anything , The test instance doesn't seem to be working, I wonder if it should have been rasied against the hotfix/2.5.3 branch? |
thecalcc
approved these changes
Nov 7, 2023
|
@marwoodandrew I checked it again and in fact it didn't work when simulating a slower network. I've added a interval to work around this. We'll be throwing out angular-based authoring code so I'm not putting time in a cleaner solution. |
|
@tomaskikutis, that seems to work, thank you! |
marwoodandrew
approved these changes
Nov 8, 2023
tomaskikutis
merged commit 4a7c297
into
superdesk:authoring-react-post-broadcasting
6 checks passed
tomaskikutis
added a commit
that referenced
this pull request
Nov 8, 2023
tomaskikutis
added a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDAAP-99