Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mark for highlight data #4303

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

dzonidoo
Copy link
Collaborator

@dzonidoo dzonidoo commented Aug 1, 2023

SDESK-6948

@tomaskikutis
Copy link
Member

what's wrong with CI?

@tomaskikutis
Copy link
Member

I will take a look at e2e issue

@tomaskikutis
Copy link
Member

tomaskikutis commented Aug 7, 2023

INFO: pip is looking at multiple versions of superdesk-core to determine which version is compatible with other requirements. This could take a while.
  ERROR: Could not find a version that satisfies the requirement celery[redis]<5.3,>=5.2.7 (from superdesk-core)

@petrjasek can you update e2e to work against develop server for e2e to pass? It's failing because old server is still expecting highlights to be a string. I tried updating it myself using pip-compile but it didn't work

@petrjasek
Copy link
Member

@tomaskikutis updated in #4304

@tomaskikutis
Copy link
Member

@dzonidoo update your branch from develop and see if e2e is good now

@tomaskikutis
Copy link
Member

@petrjasek I was running e2e against hotfix/2.6.5 branch as you specified, but the server still complains about the array and expects a string. Are you sure it's a correct version to use?

# GET /api/marked_for_highlights
{
    "_status": "ERR",
    "_issues": {
        "highlights": "must be of string type"
    },
    "_error": {
        "code": 400,
        "message": "Insertion failure: 1 document(s) contain(s) error(s)"
    }
}

@petrjasek
Copy link
Member

@tomaskikutis that wouldn't be atm in 2.6, so either develop or release/2.7

@tomaskikutis tomaskikutis merged commit ed5e0ff into superdesk:develop Aug 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants