add missing translation to transifex #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ export class Translations extends React.PureComponent<IProps> { | |||
| > | |||
| {'('}<b>{this.props.item.translations.length}</b>{')'} | |||
| {' '} | |||
| {gettextPlural(this.props.item.translations.length, 'translation', 'translations')} | |||
| {this.props.item.translations.length === 1 ? gettext('Translation') : gettext('Translations')} | |||
There was a problem hiding this comment.
you should keep gettextPlural - other languages have more plural forms than one that depend on item count (in this case translations.length) and when the script is doing string extraction, it will mark it as plural. As a result translators would have to set 3-4 or how many plural forms there are in their language.
There was a problem hiding this comment.
yep problem is that it doesn't work atm, those strings don't show up on transifex
There was a problem hiding this comment.
they are in the .pot, that part seems ok. will investigate it further this is rather temporary fix
tomaskikutis
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDCP-704