Metadata widget #4212
Merged
Metadata widget #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
css file next to tsx getAllAnnotations - type argument getLocaleName / getVocabularyItemLabel - pass arguments explicitly be more careful with optional chaining - don't use it where it's not needed |
tomaskikutis
reviewed
Apr 5, 2023
scripts/api/vocabularies.ts
Outdated
| if (value) { | ||
| subjectMerged.push(value); | ||
|
|
||
| if ((schemeName?.length ?? 0) && item.scheme !== schemeName) { |
There was a problem hiding this comment.
compare the number to something
tomaskikutis
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.