Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-6655] fix(highlights): Fixed issue with blinking loader on highlights #4180

Merged
merged 3 commits into from
Jan 13, 2023
Merged

[SDESK-6655] fix(highlights): Fixed issue with blinking loader on highlights #4180

merged 3 commits into from
Jan 13, 2023

Conversation

pavlovicnemanja
Copy link
Contributor

No description provided.

@petrjasek petrjasek added this to the 2.6 milestone Jan 12, 2023
@tomaskikutis
Copy link
Member

tomaskikutis commented Jan 12, 2023 •
edited
Loading

Before ui-framework v3, everything was loaded after 3 dots loading animation. Now you changed it so after 3 dots loader, there's another, placeholder-style loader. Do we even need SmoothLoader then? Or we could remove it entirely? If yes, do so

@pavlovicnemanja
Copy link
Contributor Author

Before ui-framework v3, everything was loaded after 3 dots loading animation. Now you changed it so after 3 dots loader, there's another, placeholder-style loader. Do we even need SmoothLoader then? Or we could remove it entirely? If yes, do so

Yes you are right. PR updated. We still need it on this place: ItemListAngularWrapper, but I removed it from other one

tomaskikutis
tomaskikutis approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@tomaskikutis tomaskikutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we shouldn't be removing data-test-id properties. They are used for e2e tests to find elements without relying too much on DOM structure. Even if they aren't used, it's good to keep them so we don't need to add them later when writing e2e tests.

We can keep the current PR as is, it's not a significant issue.

@petrjasek petrjasek merged commit 72eb336 into superdesk:develop Jan 13, 2023
petrjasek pushed a commit to petrjasek/superdesk-client-core that referenced this pull request Jan 13, 2023
@pavlovicnemanja @petrjasek
[SDESK-6655] fix(highlights): Fixed issue with blinking loader on hig…
c0bc8fe 
…hlights (superdesk#4180)

* fix(highlights): Fixed issue with blinking loader on highlights

* feat(smoothLoader): Remove smooth loader from application

* fix(loader): Return loader to item list angular wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

@petrjasek petrjasek Awaiting requested review from petrjasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@pavlovicnemanja @tomaskikutis @petrjasek