unmount monitoring when authoring is in full screen #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
approved these changes
Jan 3, 2022
protractor was rendering "W/element - more than one element found for locator" messages many times per second. It seems like calling a function from ng-if threw angular into a infinite digest loop
petrjasek
pushed a commit
that referenced
this pull request
Jan 24, 2022
* unmount monitoring when authoring is in full screen * Keep monitoring animation. Only disable it when switching to full screen authoring. * fix e2e tests protractor was rendering "W/element - more than one element found for locator" messages many times per second. It seems like calling a function from ng-if threw angular into a infinite digest loop * e2e fix 2 * see if animations are the cause of protractor hanging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-6348