Add a config option for top story sorting or default sorting #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the idea was to have the events with coverages on top being configurable, in theory it should be possible to use top story sorting without the coverages being on top |
Ok pushed some changes, making coverages sorting based on config and top story sorting is unconditional. In practice if we don't have top stories items would fall back to the default order, if we do top story ones will be on top. |
petrjasek
reviewed
Jun 26, 2024
newsroom/web/default_settings.py
Outdated
| @@ -396,7 +396,7 @@ | |||
| "button_label": lazy_gettext("Completed"), | |||
| }, | |||
| }, | |||
| "agenda_top_story_sorting": False, | |||
| "agenda_top_story_sorting_only": True, | |||
There was a problem hiding this comment.
would call it probably agenda_sort_events_with_coverage_on_top or something to be more descriptive
petrjasek
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHUB-514
Checklist
lodash.getwith optional chaining for modified code segments