Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Content Activity and Subscriber Activity reports print functionality #963

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

eos87
Copy link
Contributor

@eos87 eos87 commented Jun 20, 2024

Purpose

This PR fixes both bug connected with the print functionality of the Content Activity and Subscriber Activity reports.

What has changed

  • The query parameters representing the filters of the reports were missing when calling the print view
  • Missing window.locale value was producing breaking the print view UI

How to test

  • Checkout branch and run the project
  • Go to Content Activity and/or Subscriber Activity reports, select some filters
  • Run "Print Report" and observe that it works as expected

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

Thanks for checking!

Resolves: CPCN-637 & CPCN-636

The problem is solved by adding the missing query parameters what were producing the 500 error in the backend side.

CPCN-637
@eos87 eos87 requested a review from petrjasek June 20, 2024 14:07
@eos87 eos87 changed the title [CPCN-637] & [CPCN-636] - Fix Content Activity and Subscriber Activity reports print functionality Fix Content Activity and Subscriber Activity reports print functionality Jun 20, 2024
@petrjasek petrjasek added this to the v2.8 milestone Jun 21, 2024
@eos87 eos87 merged commit 13e0481 into develop Jun 24, 2024
17 checks passed
@eos87 eos87 deleted the hg/CPCN-637-print-content-activity-bug branch June 24, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants