New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove top level jasmine-core dependency #823

Merged

petrjasek merged 3 commits into superdesk:develop from petrjasek:chore-remove-jasmine-core

Mar 4, 2024

Member

petrjasek commented Mar 4, 2024 •

edited

Loading

it's required via karma-jasmine

Checklist

This pull request is not adding new forms that use redux
This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
This pull request is replacing lodash.get with optional chaining for modified code segments


          remove top level jasmine-core dependency

5a887b2

it's required via karma-jasmine

petrjasek requested a review from devketanpro

March 4, 2024 11:48


          remove isomorphic-fetch dependency

5e15b93

seems like it's not used

petrjasek added dependencies javascript labels


          fix flaky test

f2fe129

devketanpro approved these changes

View reviewed changes

petrjasek merged commit dc8478d into superdesk:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies javascript