Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The date in the downloaded Plain text file is not the event date [CPCN-388] #687

Merged
merged 18 commits into from
Dec 22, 2023
Merged

fix: The date in the downloaded Plain text file is not the event date [CPCN-388] #687

merged 18 commits into from
Dec 22, 2023

Conversation

devketanpro
Copy link
Member

@devketanpro devketanpro commented Dec 7, 2023 •
edited
Loading

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@petrjasek petrjasek added this to the v2.6 milestone Dec 8, 2023
@devketanpro devketanpro marked this pull request as draft December 13, 2023 14:53
petrjasek
petrjasek reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@petrjasek petrjasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add tests for the format_event_datetime all cases ideally

newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
MarkLark86
MarkLark86 reviewed Dec 15, 2023
View reviewed changes
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
@devketanpro devketanpro marked this pull request as ready for review December 15, 2023 07:09
MarkLark86
MarkLark86 reviewed Dec 17, 2023
View reviewed changes
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Show resolved Hide resolved
petrjasek
petrjasek requested changes Dec 18, 2023
View reviewed changes
newsroom/template_filters.py Outdated Show resolved Hide resolved
petrjasek
petrjasek reviewed Dec 19, 2023
View reviewed changes
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
newsroom/template_filters.py Outdated Show resolved Hide resolved
@devketanpro devketanpro merged commit 431a1df into superdesk:develop Dec 22, 2023
7 checks passed
@devketanpro devketanpro deleted the CPCN-388 branch December 22, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrjasek petrjasek petrjasek approved these changes

@MarkLark86 MarkLark86 Awaiting requested review from MarkLark86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@devketanpro @petrjasek @MarkLark86