Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display expiry date on Preview and Detail View for a segment of a TV/radio transcript #685

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

dzonidoo
Copy link
Contributor

@dzonidoo dzonidoo commented Dec 6, 2023

CPCN-30

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

return null;
}

const label = get(filterGroupLabels, 'expiry', gettext('Expiry Date'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no get pls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so label is just const label = gettext('Expirt Date'); ???

@petrjasek petrjasek added this to the v2.6 milestone Dec 7, 2023
@petrjasek petrjasek merged commit 355956f into superdesk:develop Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants