fix picture text card display error with missing picture #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkLark86
reviewed
Nov 27, 2023
|
|
||
| const getPictureTextPanel = (item: any, picture: any, openItem: any, withPictures: any, cardId: any, listConfig: any) => { | ||
| const rendition = withPictures && getThumbnailRendition(picture); | ||
| const getPictureTextPanel = (item: any, picture: IArticle | null, openItem: any, withPictures: boolean, cardId: any, listConfig: any) => { |
There was a problem hiding this comment.
I believe we could also have types for the other arguments here.
- item: IArticle;
- openItem(IArticle, string): void;
- cardId: string;
- listConfig: IListConfig
MarkLark86
approved these changes
Nov 27, 2023
petrjasek
added a commit
that referenced
this pull request
Nov 28, 2023
* fix picture text card display error with missing picture CPCN-488 * add missing types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPCN-488
Checklist
lodash.getwith optional chaining for modified code segments