Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I want to export my selected events in csv format [CPCN-15] #653

Merged
merged 20 commits into from
Nov 7, 2023
Merged

As a user I want to export my selected events in csv format [CPCN-15] #653

merged 20 commits into from
Nov 7, 2023

Conversation

devketanpro
Copy link
Member

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@devketanpro devketanpro changed the title add new formatter CSV As a user I want to export my selected events in csv format [CPCN-15] Nov 3, 2023
@devketanpro devketanpro marked this pull request as ready for review November 3, 2023 10:22
@petrjasek petrjasek added this to the v2.6 milestone Nov 3, 2023
@petrjasek
Copy link
Member

actually I'm wondering now - does it handle multiple items?

@devketanpro
Copy link
Member Author

actually I'm wondering now - does it handle multiple items?

yep it is

@petrjasek
Copy link
Member

so if you select multiple events you get 1 csv file with multiple rows?

@devketanpro
Copy link
Member Author

so if you select multiple events you get 1 csv file with multiple rows?

no we get zip contains multiple csv files

@petrjasek
Copy link
Member

I think we should change it to be able to get a single csv with multiple items

newsroom/wire/views.py Outdated Show resolved Hide resolved
newsroom/agenda/formatters/csv_formatter.py Outdated Show resolved Hide resolved
newsroom/agenda/formatters/csv_formatter.py Outdated Show resolved Hide resolved
newsroom/agenda/formatters/csv_formatter.py Outdated Show resolved Hide resolved
newsroom/agenda/formatters/csv_formatter.py Show resolved Hide resolved
@devketanpro devketanpro merged commit 56f1632 into superdesk:develop Nov 7, 2023
7 checks passed
@devketanpro devketanpro deleted the CPCN-15 branch November 7, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants