Wire-Filter e2e #648
Merged
Wire-Filter e2e #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
reviewed
Oct 31, 2023
| import {setup, addDefaultResources, addResources, addAllWireItems} from '../../support/e2e'; | ||
| import {NewshubLayout} from '../../support/pages/layout'; | ||
|
|
||
| export const WIRE_ITEMS = { |
There was a problem hiding this comment.
are those any different to those ?
There was a problem hiding this comment.
yep... in created date...
| @@ -5,7 +5,7 @@ export default function FilterItem({bucket, group, toggleFilter, groupFilter}: a | |||
| const isActive = groupFilter.indexOf(bucket.key) !== -1; | |||
|
|
|||
| return ( | |||
| <div className="form-check"> | |||
| <div className="form-check" data-test-id="checkbox" data-test-value={bucket.key}> | |||
There was a problem hiding this comment.
not sure if we need that, is checkbox really an id if it's used many times?
something like
data-test-id={`filter-${bucket.key}`}might be better
| /** | ||
| SEARCH | ||
| */ | ||
| cy.get('[data-test-id="sidenav-link-wire"]').click(); |
There was a problem hiding this comment.
would be good to extend the wire page helper and add methods like:
wirePage.openSideNav();
wirePage.search('Sydney');this would make it more readable in general
petrjasek
reviewed
Nov 2, 2023
|
|
||
| cy.url().should('include', 'Sydney'); | ||
|
|
||
| cy.get(`[data-test-id="wire-item"][data-test-value="${WIRE_ITEMS.syd_weather_1._id}"]`).should('exist'); | ||
| cy.get(`[data-test-id="wire-item"][data-test-value="${WIRE_ITEMS.bris_traffic_1._id}"]`).should('not.exist'); | ||
| cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_1._id}"]`).should('exist'); |
There was a problem hiding this comment.
you could also make a helper for this like WirePage.item(WireItems.item_1).should('exist');
petrjasek
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHUB-433