Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require replacing lodash.get with optional chaining for modified code #625

Conversation

tomaskikutis
Copy link
Member

When using lodash.get, typescript sees fields as strings and can't provide support for finding usages, renaming and validation of types in general.

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence

@tomaskikutis tomaskikutis marked this pull request as ready for review October 20, 2023 09:53
@petrjasek petrjasek added this to the v2.6 milestone Oct 23, 2023
@petrjasek petrjasek merged commit ba78095 into superdesk:develop Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants