improve saml config options #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can set on company email domain which will be tested when authenticating via saml and if user email matches it it will assign the company to user. there is also new config for custom client saml configs which allows us to configure user specific login page which picks the config to be used for SAML auth. then it uses the company domain to match the config value. STTNHUB-222
MarkLark86
approved these changes
May 26, 2023
| @@ -81,6 +81,14 @@ export function EditCompanyDetails({company, companyTypes, users, errors, onChan | |||
| error={errors ? errors.contact_email : null} | |||
| /> | |||
|
|
|||
| <TextInput | |||
There was a problem hiding this comment.
Should we hide this input if SSO is not enabled, as there would be no need to show an input that has no affect.
newsroom/auth/views.py
Outdated
| @@ -255,3 +255,11 @@ def set_locale(): | |||
| if locale and locale in app.config["LANGUAGES"]: | |||
| flask.session["locale"] = locale | |||
| return flask.redirect(flask.url_for("auth.login")) | |||
|
|
|||
|
|
|||
| @blueprint.route("/login/<client>", methods=["GET"]) | |||
There was a problem hiding this comment.
Would this be better off in newsroom.auth.saml file instead, so we're not adding an endpoint that has no use if SSO is not enabled?
| <div class="card-body pt-1"> | ||
| <form class="form" role="form" method="post" action="{{ url_for('auth.set_locale') }}"> | ||
| <div class="form-group"> | ||
| <label for="language">{{ gettext('Language') }}</label> |
There was a problem hiding this comment.
id attribute matching this for is missing on the select tag
petrjasek
added a commit
to petrjasek/newsroom-core
that referenced
this pull request
Jun 1, 2023
* improve saml config options we can set on company email domain which will be tested when authenticating via saml and if user email matches it it will assign the company to user. there is also new config for custom client saml configs which allows us to configure user specific login page which picks the config to be used for SAML auth. then it uses the company domain to match the config value. STTNHUB-222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can set on company email domain which will be tested when authenticating via saml and if user email matches it it will assign the company to user.
there is also new config for custom client saml configs which allows us to configure user specific login page which picks the config to be used for SAML auth. then it uses the company domain to match the config value.
STTNHUB-222