sclang bugfix: proper handling of Open Sound Control Blob Arguments #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, only one OSC Blob argument can be read by sclang and when intermingled with other arguments it only consistently works as last argument: works with current sclang: /test b 0x01 -> [[0x01]] /test ib 12 0x01 -> [12, [0x01]] does not work with current sclang: /test bb 0x01 0x02 -> [[0x01], [0x01]] /test bi 0x01 12 -> [[0x01], [0x01]] The problem is that the tag counter (msg.tag) is not increased as intended, because MsgToInt8Array clones the sc_msg_iter struct. Using a reference argument in MsgToInt8Array fixes the problem. does now work: /test bb 0x01 0x02 -> [[0x01], [0x02]] /test bi 0x01 12 -> [[0x01], 12]
timblechmann
added a commit
that referenced
this pull request
Jun 25, 2013
sclang bugfix: proper handling of Open Sound Control Blob Arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, only one OSC Blob argument can be read by sclang and when intermingled with other arguments it only consistently works as last argument:
works with current sclang:
/test b 0x01 -> [[0x01]]
/test ib 12 0x01 -> [12, [0x01]]
does not work with current sclang:
/test bb 0x01 0x02 -> [[0x01], [0x01]]
/test bi 0x01 12 -> [[0x01], [0x01]]
The problem is that the tag counter (msg.counter) is not increased as intended, because MsgToInt8Array clones the sc_msg_iter struct. Using a reference argument in MsgToInt8Array() fixes the problem.
does now work:
/test bb 0x01 0x02 -> [[0x01], [0x02]]
/test bi 0x01 12 -> [[0x01], 12]